Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows cmd: Don't type anything when pressing ALT keys alone #299

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

larskanis
Copy link
Contributor

Fixes #298

The test fails on Ubuntu, so that it's omitted on non-Windows. Obviously the meta key handling is different there.

@aycabta aycabta merged commit 40fffdf into ruby:master Jul 12, 2021
@aycabta
Copy link
Member

aycabta commented Jul 12, 2021

Thank you so much!

@larskanis
Copy link
Contributor Author

@aycabta Thanks for merging! I'm not sure about the test case though. I just noticed that the 8th character bit is treated as the ALT key in yamatanooroti, so I used it to test for the ALT key press, but did not understand it fully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Windows cmd: Typing brackets prepends a meta character
2 participants