Undo and redo should restore indentation #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Undo and redo should not perform auto indentation. It should not change the indentation. Instead, it should restore previous indentation.
tompng
force-pushed
the
undo_redo_restores_indentation
branch
from
b50e7ad to
c7b5fe7
Compare
ima1zumi
reviewed
Dec 12, 2024
lib/reline/line_editor.rb
Outdated
| @@ -2368,24 +2356,23 @@ def finish | |||
| @config.editing_mode = :vi_insert | |||
| end | |||
|
|
|||
| private def undo(_key) | |||
| private def move_undo_redo(direction) | |||
| @undoing = true | |||
There was a problem hiding this comment.
Now it represents both undo and redo. How about changing it to restoring?
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Dec 12, 2024
(ruby/reline#793) * Undo and redo should restore indentation Undo and redo should not perform auto indentation. It should not change the indentation. Instead, it should restore previous indentation. * Rename ivar undoing(undoing or redoing) to restoring ruby/reline@6355a6e0b2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Undo and redo should not perform auto indentation. It should not change the indentation. Instead, it should restore previous indentation and revert to the previous state.
Paste
" 1\n 2"Paste
" 1\n 2"Undo
Redo