Fix error handling when parsing XML via IO.pipe #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naitoh
force-pushed
the
fix_io_pipe_error
branch
from
d43ac92 to
1a46a02
Compare
naitoh
changed the title
naitoh
force-pushed
the
fix_io_pipe_error
branch
from
1a46a02 to
f086964
Compare
kou
reviewed
Nov 17, 2024
lib/rexml/source.rb
Outdated
| @@ -321,7 +321,7 @@ def current_line | |||
| rescue | |||
| end | |||
| @er_source.seek(pos) | |||
| rescue IOError | |||
| rescue IOError, Errno::EPIPE, Errno::ESPIPE, Errno::EINVAL | |||
There was a problem hiding this comment.
We can use SystemCallError that is an ancestor class of them:
Suggested change
| rescue IOError, Errno::EPIPE, Errno::ESPIPE, Errno::EINVAL | |
| rescue IOError, SystemCallError |
## Why? If via IO.pipe, `IOError` exception is not raised, but `Errno::ESPIPE` or `Errno::EPIPE` or `Errno::EINVAL` exception is raised. - CRuby ``` @er_source.pos #=> Errno::ESPIPE Exception: Illegal seek ``` - CRuby (Windows (Ruby 2.6 or earlier)) ``` @er_source.pos #=> Errno::EINVAL: Invalid argument ``` - JRuby ``` @er_source.pos #=> Errno::EPIPE: Broken pipe - No message available ``` Co-authored-by: Sutou Kouhei <[email protected]>
naitoh
force-pushed
the
fix_io_pipe_error
branch
from
f086964 to
a997cb1
Compare
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
If via IO.pipe,
IOErrorexception is not raised, butErrno::ESPIPEorErrno::EPIPEorErrno::EINVALexception is raised.