Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ubuntu-24.04-x64 #596

Merged
merged 4 commits into from
May 20, 2024
Merged

Support ubuntu-24.04-x64 #596

merged 4 commits into from
May 20, 2024

Conversation

kachick
Copy link
Member

@kachick kachick commented May 14, 2024 •
edited
Loading

Resolves #595

As I understand it, ruby/ruby-builder#17 is needed as a preparation task

@toadjaune toadjaune mentioned this pull request May 15, 2024
Closed
@oliverklee oliverklee mentioned this pull request May 17, 2024
Merged
@kachick kachick marked this pull request as ready for review May 19, 2024 14:17
@eregon
Copy link
Member

eregon commented May 19, 2024

Could you also list 24.04 in the README?

eregon
eregon reviewed May 19, 2024
View reviewed changes
.github/workflows/test.yml
@@ -33,6 +33,7 @@ jobs:
exclude:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you exclude 1.9 on 24.04? (see linked issue)
I scheduled a second run on ruby-builder but I guess it will fail too.

eregon
eregon reviewed May 19, 2024
View reviewed changes
.github/workflows/test.yml Outdated
@@ -33,6 +33,7 @@ jobs:
exclude:
# https://github.com/ruby/setup-ruby/issues/496
- { os: ubuntu-22.04, ruby: '2.2' }
# - { os: ubuntu-24.04, ruby: '2.2' }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you either remove this line if unneeded or if the build does fail then uncomment it?

@eregon
Copy link
Member

eregon commented May 19, 2024 •
edited
Loading

CI should be close to passing on the next run, but we still need to update the 3 -dev-builder repos (EDIT: done).

@eregon
Copy link
Member

eregon commented May 20, 2024

For ruby-head and jruby-head we have a cyclic dependency:
https://github.com/ruby/ruby-dev-builder/actions/runs/9148670190/job/25151463375
https://github.com/ruby/jruby-dev-builder/actions/runs/9148670127/job/25151463255
So we'll have to merge those as red or exclude them, I think merging as red is fine for this case.

@eregon eregon merged commit 7dc18ff into ruby:master May 20, 2024
196 of 201 checks passed
@kachick
Copy link
Member Author

kachick commented May 20, 2024

Thank you! 🙏

@kachick kachick deleted the support-ubuntu-2404-runner branch May 20, 2024 10:09
@kachick kachick mentioned this pull request Oct 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Faild in ubuntu-24.04 runner
2 participants
@kachick @eregon