Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some indentation width inconsistencies #1248

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

herwinw
Copy link
Member

@herwinw herwinw commented Feb 24, 2025

These have been found with the Layout/IndentationWidth rule of Rubocop. Because there were some false negatives (and some instances where quarantine! was used without indenting the inner block, which may have been a specific style choice), the cop itself has not been enabled.

These have been found with the Layout/IndentationWidth rule of Rubocop.
Because there were some false negatives (and some instances where
`quarantine!` was used without indenting the inner block, which may have
been a specific style choice), the cop itself has not been enabled.
@eregon eregon merged commit 47667e1 into ruby:master Feb 24, 2025
14 checks passed
@eregon
Copy link
Member

eregon commented Feb 24, 2025

Thanks.
It'd be nice to enable it but we'd need it to ignore indention within quarantine! blocks, which I guess the cop doesn't support.
We could reindent code under quarantine! but the real problem would be failing CI here whenever some spec is quarantine!, that seems too annoying.

@herwinw herwinw deleted the layout_indentationwidth branch February 24, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants