Rakefile: Update the test task to pass on Ubuntu jammy s390x. #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put the language syntax defining the default behaviors first and aligning with ruby/ruby's .travis,yml.
This reverts commit 9f3b9c4 because we will fix the issue on alternative way.
junaruga
force-pushed
the
wip/s390x-dfltcc-rakefile
branch
from
76e1eb4 to
18ab39e
Compare
junaruga
changed the title
This was referenced Sep 29, 2023
jeremyevans
approved these changes
Sep 29, 2023
|
Thanks for reviewing it. I merged the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a rework for the #63, to make the workaround simple. Because I was inspired by the comment at ruby/spec#1084 (comment).
The PR has 3 commit.
The 1st commit is to improve
.travis.ymlprinting the used zlib deb package version and other info.The 2nd commit reverts the commit 9f3b9c4.
The 3rd commit is the main commit for this PR, setting the environment variable
DFLTCC=0. When runningtest/**/test_*.rb"as a child process from the Ruby code in theRakefileas a parent process. the environment variable can affect to the tests in the test file. I referred to the way oftesttask calling thetest-internal, seeing the following ruby/openssl'sRakefile.https://github.com/ruby/openssl/blob/6b3dd6a372c5eabc88bf35a312937ee3e1a6a105/Rakefile#L21-L35
I confirmed that the Travis CI passing in my forked repository. When running 2 times, the total running times are 28 seconds and 31 seconds. So, it's faster than GitHub Actions around 2 minutes 30 seconds ~ 7 minutes
.
@jeremyevans Could you review? The change is essentially only for the 3rd commit, as I was able to revert the 2nd commit without conflict.