feat: check .codeowner within directory if it is provided to for_file
#77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
att14
force-pushed
the
codeowner-for-file-directory
branch
from
71fa38a to
ef269d2
Compare
alexevanczuk
reviewed
Oct 2, 2023
There was a problem hiding this comment.
This seems fine to me! @shageman would you be able to verify this on the Gusto codebase?
att14
force-pushed
the
codeowner-for-file-directory
branch
from
ef269d2 to
961e9d1
Compare
pbomb
suggested changes
Oct 3, 2023
pbomb
approved these changes
Oct 3, 2023
lib/code_ownership/private/ownership_mappers/directory_ownership.rb
Outdated
Show resolved
Hide resolved
lib/code_ownership/private/ownership_mappers/directory_ownership.rb
Outdated
Show resolved
Hide resolved
|
We confirmed that this works with Gusto's codebase. Please fix the conflicts and we'll merge the PR. Thanks for the contribution! |
perryqh
approved these changes
Dec 1, 2023
This was referenced Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a directory is provided to
codownership for_filecheck that directory for the presence of a.codeownerfile.