Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add total of FMVs to Purchase Index; Fix pagination of Amount spent #4746

Closed
3 tasks
cielf opened this issue Oct 27, 2024 · 12 comments · Fixed by #4847
Closed
3 tasks

Add total of FMVs to Purchase Index; Fix pagination of Amount spent #4746

cielf opened this issue Oct 27, 2024 · 12 comments · Fixed by #4847

Comments

@cielf
Copy link
Collaborator

cielf commented Oct 27, 2024

Summary

Add a total of the Fair Market Values to the Purchase index, and paginate the amount spent

Why

Useful information for the banks

Details

The purchase index is reached by signing in on your local copy as [email protected], then clicking on Purchases, then All Purchases in the left-hand menu
There is a dollar amount in the totals, but it is the amount spent, We want to also have the Full Market Value total (the column to the right of the amount spent)

Both the amount spent and the FMV should be paginated similar to the quantity of items.

Criteria for completion

  • Amount spent shows page totals in the same manner as the quantity of items
  • FMV total added, with page totals in the same manner as the quantity of items
  • automated tests to demonstrate the above behaviour
@cielf cielf added Help Wanted Groomed + open to all! Difficulty—Beginner labels Oct 27, 2024
@ethanernst11
Copy link

I can work on this one.

@cielf
Copy link
Collaborator Author

cielf commented Oct 29, 2024

Please do!

@github-actions github-actions bot removed the Help Wanted Groomed + open to all! label Oct 29, 2024
Copy link
Contributor

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Automatically unassigned after 7 days of inactivity.

@cielf cielf added Help Wanted Groomed + open to all! and removed stale labels Dec 6, 2024
@Hungle2911
Copy link
Contributor

I would like to work on this one

@cielf
Copy link
Collaborator Author

cielf commented Dec 10, 2024

Please do!

@github-actions github-actions bot removed the Help Wanted Groomed + open to all! label Dec 10, 2024
@cielf
Copy link
Collaborator Author

cielf commented Dec 10, 2024

For clarification, we currently have a total for Amount Spent (column A on the screenshot) - but it needs pagination. We also need a total (with pagination) for FMV (column B)

Screenshot 2024-12-10 at 2 09 49 PM

@Hungle2911
Copy link
Contributor

Thank you for your clarification. Just want to make sure we are on the same page, we will separate it into two pages so the first page will contain everything but the column B and the second one will contain everything but the column A. The end result will look somewhat like this right?
Screenshot 2024-12-10 at 1 56 23 PM

@cielf
Copy link
Collaborator Author

cielf commented Dec 10, 2024

@Hungle2911 -- No -- that's not what we want -- don't think about the inventory page at all (sorry for the language that led you down that path)

We want to add totals for the Fair Market Value to the current purchase index page.
And both the Fair Market Value and amount spent totals should have the pagination behaviour -- like we have for quantity of items on that page.

It'll look more like the Distributions page -- only with 3 columns that have totals, instead of just the two that page has.

@Hungle2911
Copy link
Contributor

Oh, I think I get it now. Sorry, I was a little bit confused because this is my first issue. Thank you so much for clarification.

@cielf
Copy link
Collaborator Author

cielf commented Dec 11, 2024

Not your fault -- there was some legitimately bad wording in it.

Copy link
Contributor

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

@github-actions github-actions bot added the stale label Jan 11, 2025
dorner pushed a commit that referenced this issue Jan 12, 2025
… Amount spent (#4847)

* feat: add total amount spent and FMV with pagination behaviour

* fix: use paginated_purchases to calculate paginated_fair_market_values

* fixing mis-merge

---------

Co-authored-by: CL Fisher <[email protected]>
Co-authored-by: CL Fisher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants