Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable historical cache job #4073

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Temporarily disable historical cache job #4073

merged 2 commits into from
Feb 1, 2024

Conversation

dorner
Copy link
Collaborator

@dorner dorner commented Feb 1, 2024

See issue #4064 . This way it'll only run if the env variable is set.

@dorner dorner requested a review from cielf February 1, 2024 01:08
Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorner Looks good to me. I'll leave the merging to you so you can set the variable on staging at the same time. Thanks.

@dorner
Copy link
Collaborator Author

dorner commented Feb 1, 2024

It's OK to leave the env variable off for now on staging - we really only need to turn it on while doing testing.

@dorner dorner merged commit fda0438 into main Feb 1, 2024
12 checks passed
@dorner dorner deleted the disable-cache-job branch February 1, 2024 14:58
@awwaiid
Copy link
Collaborator

awwaiid commented Feb 2, 2024

Should we go ahead with an off-schedule production deploy?

@cielf
Copy link
Collaborator

cielf commented Feb 2, 2024

@awwaiid Ehn. Not during business hours, certainly. I would consider it for tonight -- Do we have a sense of how long it will take to clear out the backlog of jobs?

@dorner
Copy link
Collaborator Author

dorner commented Feb 2, 2024

We should clear them out manually. I can put in a PR for this too.

@cielf
Copy link
Collaborator

cielf commented Feb 2, 2024

We'd just be clearing out the historicals, right? Leaving the email jobs? I think we are going to have some noise from the banks whichever way we go on that.

@dorner
Copy link
Collaborator Author

dorner commented Feb 2, 2024

Yep.

Copy link
Contributor

github-actions bot commented Feb 4, 2024

@dorner: Your PR Temporarily disable historical cache job is part of today's Human Essentials production release: 2024.02.04.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants