Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4672 header alignment #4716

Closed
wants to merge 14 commits into from
Closed

4672 header alignment #4716

wants to merge 14 commits into from

Conversation

inane-pixel
Copy link
Contributor

@inane-pixel inane-pixel commented Oct 11, 2024 •
edited by cielf
Loading

Resolves #4672

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
    item_row.distribution_quantity aligned right and FMV aligned right

How Has This Been Tested?

Screenshots

@cielf
Copy link
Collaborator

cielf commented Oct 11, 2024

If anyone else is reviewing this, please refer to PR 4715 and issue 4672

cielf

This comment was marked as duplicate.

Sign in to view

cielf
cielf requested changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to say "Looks good to me", but then looked at the commits and noticed that you've somehow managed to back out of changes that were already in place -- changing a lot more files than I think you meant to?

cielf
cielf requested changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@inane-pixel Closer, but the config and migrate changes you made are not related to the matter at hand.

@cielf
Copy link
Collaborator

cielf commented Oct 14, 2024

@inane-pixel Still showing extra changes.

@inane-pixel
Copy link
Contributor Author

@cielf What are the extra changes? I did delete db/migrate/20180704003450_create_flipper_tables.rb, but I was recommended to do that in the Slack channel because I was receiving error messages with createFlipperTables
image

@cielf
Copy link
Collaborator

cielf commented Oct 20, 2024

Asking for a review from @awwaiid

@cielf cielf requested a review from awwaiid October 20, 2024 03:19
@cielf
Copy link
Collaborator

cielf commented Oct 20, 2024

It looks to me like you've made unrelated changes to database.yml, and that you deleted a migration from 2018 -- @awwaiid mentioned a migration from 2024.

@inane-pixel
Copy link
Contributor Author

@cielf I see the errors now. I tried making and committing a new branch, hopefully without the extra changes. 4730

@cielf
Copy link
Collaborator

cielf commented Oct 23, 2024

Closing this PR because there is a replacement

@cielf cielf closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cielf cielf cielf requested changes

@awwaiid awwaiid Awaiting requested review from awwaiid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Header Alignment -- on all things
2 participants
@inane-pixel @cielf