rubyforgood · coalest · Oct 4, 2024 · Oct 4, 2024 · Sep 25, 2024 · Oct 6, 2024
diff --git a/app/controllers/partners_controller.rb b/app/controllers/partners_controller.rb
@@ -1,5 +1,5 @@
 # Provides full CRUD for Partners. These are minimal representations of corresponding Partner records in PartnerBase.
-# Though the functionality of Partners is actually fleshed out in PartnerBase, in HumanEssentails, we maintain a collection
+# Though the functionality of Partners is actually fleshed out in PartnerBase, in HumanEssentials, we maintain a collection
 # of which Partners are associated with which Diaperbanks.
 class PartnersController < ApplicationController
   include Importable

diff --git a/app/controllers/transfers_controller.rb b/app/controllers/transfers_controller.rb
@@ -49,7 +49,7 @@ def destroy
     results = transfer_destroy_service.call
 
     if results.success?
-      flash[:notice] = "Succesfully deleted Transfer ##{params[:id]}!"
+      flash[:notice] = "Successfully deleted Transfer ##{params[:id]}!"
     else
       flash[:error] = results.error.message
     end

diff --git a/app/javascript/controllers/checkbox_with_nested_element_controller.js b/app/javascript/controllers/checkbox_with_nested_element_controller.js
@@ -8,14 +8,14 @@ export default class extends Controller {
   static targets = [ "nestedElement", "checkbox" ]
 
   connect() {
-    this.toggleNestedElementVisiblity()
+    this.toggleNestedElementVisibility()
   }
 
   /**
    * Toggles the visibility of the nested element depending
    * on wither the checkbox is checked or not.
    */
-  toggleNestedElementVisiblity() {
+  toggleNestedElementVisibility() {
     this.nestedElementTarget.classList.toggle("d-none", !this.checkboxTarget.checked)
   }
 

diff --git a/app/models/item.rb b/app/models/item.rb
@@ -74,7 +74,7 @@ class Item < ApplicationRecord
   # 4/  Period supplies.  All things with 'menstrual in the category'
   # 5/  Other -- Miscellaneous, and wipes
   # Known holes and ambiguities as of 20240527.  Working on these with the business
-  # 1/  Liners.   We are adding a new item for AI liners,  and renaming the current liners to be specficially for periods,
+  # 1/  Liners.   We are adding a new item for AI liners,  and renaming the current liners to be specifically for periods,
   # having confirmed with the business that the majority of liners are for menstrual use.
   # However, there is a product which can be used for either, so we are still sussing out what to do about that.
 

diff --git a/app/models/partners/child.rb b/app/models/partners/child.rb
@@ -33,8 +33,8 @@ class Child < Base
     scope :from_family, ->(family_id) {
       where(family_id: family_id)
     }
-    scope :from_children, ->(chidren_id) {
-      where(id: chidren_id)
+    scope :from_children, ->(children_id) {
+      where(id: children_id)
     }
     scope :active, -> { where(active: true) }
 

diff --git a/app/services/distribution_totals_service.rb b/app/services/distribution_totals_service.rb
@@ -45,7 +45,7 @@ def calculate_quantities(distributions)
       .to_h
   end
 
-  # Returns hash of total value of items per distribution WIHOUT item id/category filter
+  # Returns hash of total value of items per distribution WITHOUT item id/category filter
   # Value of entire distribution (not reduced by filtered items)
   #
   # @return [Hash<Integer, Integer>]

diff --git a/app/services/exports/export_request_service.rb b/app/services/exports/export_request_service.rb
@@ -85,7 +85,7 @@ def compute_item_headers
       end
 
       # Adding this to handle cases in which a requested item
-      # has been deleted. Normally this wouldn't be neccessary,
+      # has been deleted. Normally this wouldn't be necessary,
       # but previous versions of the application would cause
       # this orphaned data
       item_names.sort.uniq << DELETED_ITEMS_COLUMN_HEADER

diff --git a/app/services/service_object_errors_mixin.rb b/app/services/service_object_errors_mixin.rb
@@ -1,7 +1,7 @@
 module ServiceObjectErrorsMixin
   #
   # This module is can be included into service object like
-  # classes so that they get the similiar interface commonly used
+  # classes so that they get the similar interface commonly used
   # by active records. Here is an example of a how you could interact
   # with a service object with this included.
   #

diff --git a/app/views/admin/organizations/index.html.erb b/app/views/admin/organizations/index.html.erb
@@ -36,7 +36,7 @@
                 <div class="col-3">
                   <%= render_filterrific_spinner %>
                 </div>
-                <div clas="col-9">
+                <div class="col-12">
                   <div class="float-right">
                     <%= new_button_to new_admin_organization_path, { text: "Add New Organization" } %>
                   </div>

diff --git a/app/views/distributions/show.html.erb b/app/views/distributions/show.html.erb
@@ -92,7 +92,7 @@
             <%= print_button_to print_distribution_path(@distribution, format: :pdf), {size: "md"} %>
           </div>
           <% if @distribution.has_inactive_item? %>
-            <div class="low_prioirty_warning">
+            <div class="low_priority_warning">
               You can only correct distributions where all the items are active.
               If you need to make a correction, please make the following items active: <%= @distribution.inactive_items.map(&:name).join(", ") %>
             </div>

diff --git a/app/views/kits/allocations.html.erb b/app/views/kits/allocations.html.erb
@@ -163,7 +163,7 @@
 
         let baseQuantity = rowElement.attr('data-base-quantity');
         // Utilize the -1 to properly make the base kit item
-        // go negative when the content goes postive
+        // go negative when the content goes positive
         let newText = -1 * changeBy * baseQuantity
         rowElement.text(newText);
 

diff --git a/app/views/layouts/application_old.html.erb b/app/views/layouts/application_old.html.erb
@@ -27,7 +27,7 @@
       <a href="<%= root_path %>" class="logo">
     <% end %>
     <!-- mini logo for sidebar mini 50x50 pixels -->
-    <span class="logo-mini"><img src="/img/diaper-base-logo-icon.svg" alt="Essentails Logo (icon)" title="Human Essentials">
+    <span class="logo-mini"><img src="/img/diaper-base-logo-icon.svg" alt="Essentials Logo (icon)" title="Human Essentials">
     </span>
     <!-- logo for regular state and mobile devices -->
     <span class="logo-lg"><%= image_tag "/img/essentials.svg", alt: "Human Essentials Logo", id: "logo" %></span>

diff --git a/app/views/partner_groups/_form.html.erb b/app/views/partner_groups/_form.html.erb
@@ -22,7 +22,7 @@
 
               <div class='mt-3' data-controller='checkbox-with-nested-element'>
                 <h2 class='text-bold text-lg'>Do you want to send deadline reminders to them every month?</h2>
-                <%= f.input :send_reminders, as: :boolean, label: "Yes", input_html: { data: { action: 'click->checkbox-with-nested-element#toggleNestedElementVisiblity', 'checkbox-with-nested-element-target': 'checkbox' } } %>
+                <%= f.input :send_reminders, as: :boolean, label: "Yes", input_html: { data: { action: 'click->checkbox-with-nested-element#toggleNestedElementVisibility', 'checkbox-with-nested-element-target': 'checkbox' } } %>
 
                 <div class='pl-5 d-none' data-checkbox-with-nested-element-target='nestedElement'>
                   <div class="callout callout-info">

diff --git a/app/views/partners/_form.html.erb b/app/views/partners/_form.html.erb
@@ -31,7 +31,7 @@
 
               <div data-controller='checkbox-with-nested-element'>
                 <%= f.input :send_reminders, label: "Do you want this partner to receive emails for distributions and reminders from the system?", wrapper: :input_group do %>
-                  <%= f.check_box :send_reminders, { class: "input-group-text", id: "send_reminders", data: { action: 'click->checkbox-with-nested-element#toggleNestedElementVisiblity', 'checkbox-with-nested-element-target': 'checkbox' } }, "true", "false" %>
+                  <%= f.check_box :send_reminders, { class: "input-group-text", id: "send_reminders", data: { action: 'click->checkbox-with-nested-element#toggleNestedElementVisibility', 'checkbox-with-nested-element-target': 'checkbox' } }, "true", "false" %>
                  <% end %>
                  <div class="callout callout-info d-none" data-checkbox-with-nested-element-target='nestedElement'>
                    <h5 class='text-uppercase font-weight-bold'>Reminder</h5>

diff --git a/app/views/partners/families/index.html.erb b/app/views/partners/families/index.html.erb
@@ -15,7 +15,7 @@
               <i class="fa fa-dashboard"></i> Home
             <% end %>
           </li>
-          <li class="breadcrumb-item"><a href="#">Familes</a></li>
+          <li class="breadcrumb-item"><a href="#">Families</a></li>
         </ol>
       </div>
     </div>

diff --git a/app/views/profiles/_show.html.erb b/app/views/profiles/_show.html.erb
@@ -12,7 +12,7 @@
     </p>
     <p>Proof of Agency Status
     <% if partner_profile.proof_of_partner_status.attached? %>
-      <!-- NOTE: The actual download link may not work in local storage mode due to file locations being seperate locally. -->
+      <!-- NOTE: The actual download link may not work in local storage mode due to file locations being separate locally. -->
       (Link): <%= link_to partner_profile.proof_of_partner_status.filename, rails_blob_path(partner_profile.proof_of_partner_status, disposition: 'inline') %>
   <% end %>
     </p>
@@ -49,7 +49,7 @@
       <p>Form 990: <%= humanize_boolean(partner_profile.proof_of_form_990.attached?) %></p>
       <p>Form 990
       <% if partner_profile.proof_of_form_990.attached? %>
-        <!-- NOTE: The actual download link may not work in local storage mode due to file locations being seperate locally. -->
+        <!-- NOTE: The actual download link may not work in local storage mode due to file locations being separate locally. -->
         (Link): <%= link_to partner_profile.proof_of_form_990.filename, rails_blob_path(partner_profile.proof_of_form_990, disposition: 'attachment') %>
     <% end %>
       </p>

diff --git a/config/application.rb b/config/application.rb
@@ -29,7 +29,7 @@ class Application < Rails::Application
 
     # Set the async mailer jobs to go through the default queue
     # that sidekiq comes with. This way `.deliver_later` will
-    # generate a job that will be processed by the exisiting
+    # generate a job that will be processed by the existing
     # sidekiq worker that is only taking work from the `default`
     # queue.
     config.action_mailer.deliver_later_queue_name = 'default'

diff --git a/config/initializers/simple_form.rb b/config/initializers/simple_form.rb
@@ -106,7 +106,7 @@
   # You can define the class to use on all labels. Default is nil.
   # config.label_class = nil
 
-  # You can define the default class to be used on forms. Can be overriden
+  # You can define the default class to be used on forms. Can be overridden
   # with `html: { :class }`. Defaulting to none.
   # config.default_form_class = nil
 

diff --git a/db/seeds.rb b/db/seeds.rb
@@ -527,7 +527,7 @@ def seed_random_item_with_name(organization, name)
 end
 Organization.all.find_each { |org| SnapshotEvent.publish(org) }
 
-# Set minimum and recomended inventory levels for the complete organizations
+# Set minimum and recommended inventory levels for the complete organizations
 # Only set inventory levels for the half of each org's items with the lowest stock
 complete_orgs.each do |org|
   half_items_count = (org.items.count / 2).to_i
@@ -540,16 +540,16 @@ def seed_random_item_with_name(organization, name)
   min_qty = low_items.first.total_quantity
   max_qty = low_items.last.total_quantity
 
-  # Ensure at least one of the items unqiue to the Second City Bank has minimum
+  # Ensure at least one of the items unique to the Second City Bank has minimum
   # and recommended quantities set
   if (org == sc_org) && !(low_items & sc_org_unique_items).any?
     low_items << sc_org_unique_items.last
   end
 
   low_items.each do |item|
     min_value = rand((min_qty / 10).floor..(max_qty / 10).ceil) * 10
-    recomended_value = rand((min_value / 10).ceil..1000) * 10
-    item.update(on_hand_minimum_quantity: min_value, on_hand_recommended_quantity: recomended_value)
+    recommended_value = rand((min_value / 10).ceil..1000) * 10
+    item.update(on_hand_minimum_quantity: min_value, on_hand_recommended_quantity: recommended_value)
   end
 end
 

diff --git a/...act-all-partner-operations-into-a-separate-application-intended-for-partners.md b/...act-all-partner-operations-into-a-separate-application-intended-for-partners.md
@@ -8,7 +8,7 @@ Accepted
 
 ## Context
 
-Partner organizations work directly with the families in need. Sometimes they will need to collect PII such as address, names and ages of family members, and other contact information. This data is not necessary for Diaperbase to operate, and there are security concerns about that PII being disclosed should there be a breach. There is also a separation of concerns between the two applications; Diaperbase is inventory management and Partnerbase is effectively a CRM. At this time, we belive that they are different enough in their purposes that they should be separate.
+Partner organizations work directly with the families in need. Sometimes they will need to collect PII such as address, names and ages of family members, and other contact information. This data is not necessary for Diaperbase to operate, and there are security concerns about that PII being disclosed should there be a breach. There is also a separation of concerns between the two applications; Diaperbase is inventory management and Partnerbase is effectively a CRM. At this time, we believe that they are different enough in their purposes that they should be separate.
 
 ## Decision
 

diff --git a/docs/user_guide/bank/getting_started_customization.md b/docs/user_guide/bank/getting_started_customization.md
@@ -105,7 +105,7 @@ You can also specify a different default Storage Location on any Partner, which
 If you specify a default Storage Location, it will be pre-populated as the Storage Location when you are adding new Distributions.
 
 #### Custom Partner Invitation Message 
-[!NOTE] The Custom Partner Invitation Message is currenty not working as advertised (as of November 13, 2024.).  The current behavior is as if you did not enter anything here.  We have fixing it on our "to do" list.
+[!NOTE] The Custom Partner Invitation Message is currently not working as advertised (as of November 13, 2024.).  The current behavior is as if you did not enter anything here.  We have fixing it on our "to do" list.
 
 When you invite a Partner, they get an email.  This field lets you specify the message you are sending to them.  Just text -- we don't have any personalization capability for this email at this time.
 

diff --git a/docs/user_guide/bank/intro_ii.md b/docs/user_guide/bank/intro_ii.md
@@ -24,7 +24,7 @@ We publish the zoom, and (when we remember) in the Announcements in Human Essent
 
 
 ### Keeping up-to-date with changes
-We release changes to the system most weeks on Sundays between 10am and noon Eastern time (the system will be down for a short period when we do).   When we do, we put up an announcment in the system, which you will see on your [dashboard](essentials_dashboard.md).   We also record them in a newsletter at: https://ruby-for-good.gitbook.io/human-essentials-news 
+We release changes to the system most weeks on Sundays between 10am and noon Eastern time (the system will be down for a short period when we do).   When we do, we put up an announcement in the system, which you will see on your [dashboard](essentials_dashboard.md).   We also record them in a newsletter at: https://ruby-for-good.gitbook.io/human-essentials-news 
 
 
 

diff --git a/docs/user_guide/bank/inventory_transfers.md b/docs/user_guide/bank/inventory_transfers.md
@@ -19,7 +19,7 @@ Specify where the Items being moved are coming from, in "From Storage Location,"
 
 The Comment field is a good place to note the reason for the Transfer, but you can leave it blank.
 
-Then select the Item and quantity for each Item that is being Transferred.  If you have [barcodes](inventory_barcodes.md) set up,  you can use your barcode reader to "boop" in the materials being Transfered.
+Then select the Item and quantity for each Item that is being Transferred.  If you have [barcodes](inventory_barcodes.md) set up,  you can use your barcode reader to "boop" in the materials being Transferred.
 
 When you are done, click "Save".  The system will check that you have enough inventory in "From" to cover the Transfer.  If so, the inventory changes will take place immediately.
 

diff --git a/docs/user_guide/bank/pm_announcements.md b/docs/user_guide/bank/pm_announcements.md
@@ -10,7 +10,7 @@ You can add multiple Announcements, with links to additional information, and ei
 
 Click on "Partner Agencies" in the left hand menu, then "Partner Announcement".   This will bring up a list of all your partner Announcements.
 
-![all announcments screen](images/partners/partners_announcements_1.png)
+![all announcements screen](images/partners/partners_announcements_1.png)
 
 Click the "New Announcements" button to bring up a form for a new Announcement
 

diff --git a/docs/user_guide/bank/pm_partner_profiles.md b/docs/user_guide/bank/pm_partner_profiles.md
@@ -98,7 +98,7 @@ How does the agency get its funding?
 ### Area Served (County/Client Share %)
 This asks what county/county equivalents the agency serves and what proportion of their client share is in which area.
 
-At this time, this only covers U.S. counties and equivalents.   We believe the list covers *all* of the U.S, including some areas that are not tecnically counties.    
+At this time, this only covers U.S. counties and equivalents.   We believe the list covers *all* of the U.S, including some areas that are not technically counties.    
 Let us know if you need more!
 
 The sum of the client share has to be either 0 or 100, and the numbers have to be positive whole numbers.

diff --git a/docs/user_guide/documentation_style_guide.md b/docs/user_guide/documentation_style_guide.md
@@ -1,14 +1,14 @@
 # Style Guide
 This style guide is for the Human Essentials Bank user guide.  
 
-Its purpose is to set the standard ways of dealing with matters of style, such as hypenation, capitalization, and the like.
+Its purpose is to set the standard ways of dealing with matters of style, such as hyphenation, capitalization, and the like.
 
 We want to do a final pass to make everything consistent with the style guide before officially launching the guide.
 
 
 ## Capitalization
 ### Headings
-In documentaion, use title case for the main header for each page,  then use sentence case (see this page as an example).
+In documentation, use title case for the main header for each page,  then use sentence case (see this page as an example).
 ### When quoting the system 
 Match the text to what is in the application.  For instance, if a button says "Manage Product drives".  That being said,  if there is something in the app that is inconsistent,  let's get that fixed.
 ### Otherwise, always capitalize

diff --git a/puma-dev.md b/puma-dev.md
@@ -15,7 +15,7 @@ puma-dev -install
 
 Link the application.
 ```
-puma-dev link -n essentials {essentails_dir}
+puma-dev link -n essentials {essentials_dir}
 ```
 
  For example, if your diaper repo clone is in `~/ruby/human-essentials`. You would run this:

diff --git a/sbv.md b/sbv.md
@@ -16,7 +16,7 @@ We welcome contributions from teams and have had great success facilitating team
 
 This is where we have defined a larger chunk of work that needs to be done, the work is fully understood, it is ready to start immediately, and we just need some people to complete it.
 
-An example of this is the theme upgrade and facelift we have planned for the project. We have created a [massive issue](https://github.com/rubyforgood/human-essentials/issues/2965) that lists all the user facing pages and files (337 of them!) that need to first be evaluated for compatibility with the new theme, and then upgraded once they are evaluted!
+An example of this is the theme upgrade and facelift we have planned for the project. We have created a [massive issue](https://github.com/rubyforgood/human-essentials/issues/2965) that lists all the user facing pages and files (337 of them!) that need to first be evaluated for compatibility with the new theme, and then upgraded once they are evaluated!
 
 #### Approach Two - You discover the work and suggest how to accomplish it
 

diff --git a/spec/controllers/transfers_controller_spec.rb b/spec/controllers/transfers_controller_spec.rb
@@ -24,7 +24,7 @@
         let!(:new_transfer) { create(:transfer, created_at: 1.day.ago) }
 
         context 'when date parameters are supplied' do
-          it 'only returns the correct obejects' do
+          it 'only returns the correct objects' do
             start_date = 3.days.ago.to_formatted_s(:date_picker)
             end_date = Time.zone.today.to_formatted_s(:date_picker)
             get :index, params: { filters: { date_range: "#{start_date} - #{end_date}" } }

diff --git a/spec/models/adjustment_spec.rb b/spec/models/adjustment_spec.rb
@@ -13,7 +13,7 @@
 
 RSpec.describe Adjustment, type: :model do
   it_behaves_like "itemizable"
-  # This mixes feature specs with model specs... idealy we do not want to do this
+  # This mixes feature specs with model specs... ideally we do not want to do this
   # it_behaves_like "pagination"
   #
   let(:organization) { create(:organization) }

diff --git a/spec/models/distribution_spec.rb b/spec/models/distribution_spec.rb
@@ -291,7 +291,7 @@
     end
 
     describe "#copy_from_request" do
-      it "copy over relevant request information into the distrubution" do
+      it "copy over relevant request information into the distribution" do
         item1 = create(:item, name: "Item1", organization: organization)
         item2 = create(:item, name: "Item2", organization: organization)
         request = create(:request,

diff --git a/spec/models/donation_spec.rb b/spec/models/donation_spec.rb
@@ -19,7 +19,7 @@
 
 RSpec.describe Donation, type: :model do
   it_behaves_like "itemizable"
-  # This mixes feature specs with model specs... idealy we do not want to do this
+  # This mixes feature specs with model specs... ideally we do not want to do this
   # it_behaves_like "pagination"
 
   context "Validations >" do

diff --git a/spec/models/item_category_spec.rb b/spec/models/item_category_spec.rb
@@ -20,7 +20,7 @@
     it { should validate_length_of(:description).is_at_most(250) }
   end
 
-  describe 'assocations' do
+  describe 'associations' do
     it { should belong_to(:organization) }
     it { should have_many(:items) }
     it { should have_and_belong_to_many(:partner_groups) }

diff --git a/spec/models/item_spec.rb b/spec/models/item_spec.rb
@@ -24,7 +24,7 @@
 RSpec.describe Item, type: :model do
   let(:organization) { create(:organization) }
 
-  describe 'Assocations >' do
+  describe 'Associations >' do
     it { should belong_to(:item_category).optional }
   end
   context "Validations >" do
Original file line number	Diff line number	Diff line change
Expand Up		@@ -24,7 +24,7 @@ We publish the zoom, and (when we remember) in the Announcements in Human Essent


		### Keeping up-to-date with changes
		We release changes to the system most weeks on Sundays between 10am and noon Eastern time (the system will be down for a short period when we do). When we do, we put up an announcment in the system, which you will see on your [dashboard](essentials_dashboard.md). We also record them in a newsletter at: https://ruby-for-good.gitbook.io/human-essentials-news
		We release changes to the system most weeks on Sundays between 10am and noon Eastern time (the system will be down for a short period when we do). When we do, we put up an announcement in the system, which you will see on your [dashboard](essentials_dashboard.md). We also record them in a newsletter at: https://ruby-for-good.gitbook.io/human-essentials-news



Expand Down