Fix typos with source code spell checker #4879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coalest
force-pushed
the
fix-typos-with-source-code-spell-checker
branch
from
47312b3 to
ff06650
Compare
|
Link to closed PR: #4871 |
dorner
approved these changes
Jan 10, 2025
|
@coalest can you fix the merge conflict? |
…ce-code-spell-checker
|
Fixed the merge conflict. This PR ends up having merge conflicts more often than normal because it touches so many files/lines, so let's merge it before others if possible. |
coalest
commented
Jan 13, 2025
| <div clas="col-9"> | ||
| <div class="col-12"> |
There was a problem hiding this comment.
From the previous review by @cielf, this was the only typo fix that caused a regression. But changing the css class fixed the issue.
|
@coalest: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't resolve any issue.
Description
I noticed a typo in a css class (prioirty instead of priority), which got me thinking maybe there are other typos in our code base.
So I found typos (a source code spell checker) and ran it on our code base. Turns out "essentials" is really hard to spell :D
Most of the typos are in comments, but some are in code so we probably need to do some manual testing here.
Type of change
How Has This Been Tested?
Not much really