Remove partner FAQs - Part 1

[jp524]

Relates to #4546.

Description

Partner FAQs aren't used anymore. The help page for partners shows the bank's name and email instead. (The issue mentions the bank's primary contact name and bank's phone, but I wasn't able to find those.)

The Question model was also modified to remove any reference to banks or partners. Because this change requires removing a column the migration needs to be to done in multiple steps based on the Strong Migrations docs.

The PR with the migration to remove the columns is #4913. This PR should be deployed prior to #4913 being deployed according to Strong Migrations docs.

Type of change

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Added request tests for /partners/help. Ensured that other tests related to bank FAQ still pass.

Screenshots

Partner Help

Admin All FAQs

Admin New FAQ

[cielf]

@jp54

Hrm. I tried adding a question/answer pair, and it did not appear when I signed in as a bank.

However I'm not sure this is working properly to start with (it's a pretty rarely used feature).

Do you want to take a swing at fixing it?

(The removal from the partner area looks good, FWIW)

[jp524]

@cielf I had a look at the missing Q&A when signed in as a bank user. It looks like only the first page (first 5 Q&A) get loaded so the new Q&A don't appear until a search is made. I'll work on a fix.

[jp524]

@cielf The bank FAQ page shows all the Q&A now.

[cielf]

LGTM from a functional pov. @dorner -- what say you on the tech side?

[dorner]

Tiny request - otherwise looks good!

[dorner]

Looks good - thanks!

[github-actions]

@jp524: Your PR Remove partner FAQs - Part 1 is part of today's Human Essentials production release: 2025.01.19.
Thank you very much for your contribution!