Perf: Fix slow selectAll and deselectAll highcharts controller methods #4927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will do. Probably tomorrow. |
|
Ok. Yup. That's an improvement, alright. |
|
@coalest: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't resolve any issue.
Description
While looking into places we use caching (for the solid_cache task), I noticed the 'Select All' and 'Deselect All' buttons in the historical trends pages were really slow.
Reason for slowness:
From this flame graph, you can see that a
redrawmethod was being called over and over again.Apparently the
showandhidemethods were redrawing the chart after every item (series) had it's visibility changed.This PR changes it so that the visibility is set for all items and then the chart is redrawn only once.
Type of change
How Has This Been Tested?
Manually. I couldn't find any system specs for these pages.
Screenshots
I also moved added a little padding to buttons.
Before
After
