-
-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update landing page to use bootstrap instead of tailwind #4942
Update landing page to use bootstrap instead of tailwind #4942
Conversation
849e39e
to
306de0f
Compare
35e0028
to
185d65a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries on technical side - over to @cielf to make sure the landing page still looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@Sukhpreet-s: Your PR |
Resolves #4395
Description
This PR updates the
landing_page
to use Bootstrap instead of Tailwind. This is to avoid the usage of 2 different UI libraries across the application and since tailwind is only used for this landing page and bootstrap can be easily utilized for this task.The
landing_page.scss
is updated by removing the old styles, which were not being used at all, and adding new styles.The flash message is updated to use
shared/_flash
and the fileshared/_flash_tailwind.html.erb
is removed.Some decisions that are made:
landing_page.scss
stylesheet is used instead of theapplication.scss
to avoid loading the unnecessary massive amount of css code just for the main page. Instead, bootstrap is imported into thelanding_page.scss
.Type of change
How Has This Been Tested?
Manually by testing all the buttons on the page, and visually checking for any styling issue including responsive design issues.
Screenshots
After
Before
Flash messages (Not sure how the flash messages are used on this page but this example is done by manually setting the flash message for testing purposes just to show how they look)