Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update landing page to use bootstrap instead of tailwind #4942

Merged

Conversation

Sukhpreet-s
Copy link
Contributor

@Sukhpreet-s Sukhpreet-s commented Jan 23, 2025

Resolves #4395

Description

This PR updates the landing_page to use Bootstrap instead of Tailwind. This is to avoid the usage of 2 different UI libraries across the application and since tailwind is only used for this landing page and bootstrap can be easily utilized for this task.

The landing_page.scss is updated by removing the old styles, which were not being used at all, and adding new styles.

The flash message is updated to use shared/_flash and the file shared/_flash_tailwind.html.erb is removed.

Some decisions that are made:

  • The landing_page.scss stylesheet is used instead of the application.scss to avoid loading the unnecessary massive amount of css code just for the main page. Instead, bootstrap is imported into the landing_page.scss.
  • The CDN for Alpine.js is removed since it is not used anywhere on the page. The dropdown code that was using it was removed in an older PR.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manually by testing all the buttons on the page, and visually checking for any styling issue including responsive design issues.

Screenshots

After

Before

Flash messages (Not sure how the flash messages are used on this page but this example is done by manually setting the flash message for testing purposes just to show how they look)

@Sukhpreet-s Sukhpreet-s force-pushed the 4395-rework-landing-page-with-bootstrap branch from 849e39e to 306de0f Compare February 3, 2025 04:06
@Sukhpreet-s Sukhpreet-s force-pushed the 4395-rework-landing-page-with-bootstrap branch from 35e0028 to 185d65a Compare February 4, 2025 07:21
@Sukhpreet-s Sukhpreet-s changed the title [WIP] Update landing page to use bootstrap instead of tailwind Update landing page to use bootstrap instead of tailwind Feb 4, 2025
@Sukhpreet-s Sukhpreet-s marked this pull request as ready for review February 4, 2025 07:24
@cielf cielf requested a review from dorner February 4, 2025 19:39
@dorner dorner requested a review from cielf February 4, 2025 23:45
Copy link
Collaborator

@dorner dorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries on technical side - over to @cielf to make sure the landing page still looks good.

Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cielf cielf merged commit e8b3026 into rubyforgood:main Feb 5, 2025
11 checks passed
Copy link
Contributor

github-actions bot commented Feb 9, 2025

@Sukhpreet-s: Your PR Update landing page to use bootstrap instead of tailwind is part of today's Human Essentials production release: 2025.02.09.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework landing page to use bootstrap instead of tailwind
3 participants