Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor CSS fixes to sign in/up flow #4943

Merged
merged 6 commits into from
Jan 24, 2025
Merged

Conversation

coalest
Copy link
Collaborator

@coalest coalest commented Jan 23, 2025

Doesn't resolve any issue.

Description

Minor CSS improvements. See screenshots below.

Type of change

  • UI related changes

(Not sure how to categorize this)

How Has This Been Tested?

Just manually (as they're almost entirely UI-only changes)

Screenshots

  • Fixed alignment of Human Essentials Logo and Google SSO button. Added asterisk to password field.
    Before
    Screenshot from 2025-01-23 13-04-23
    After
    Screenshot from 2025-01-23 13-04-39

  • Centered account request form
    Before:
    Screenshot from 2025-01-23 13-05-07
    After: (Ignore my mouse being in the way of the screenshot)
    Screenshot from 2025-01-23 13-04-51

  • Don't send modal HTML for staging warning when environment is dev or prod
    Before:
    Screenshot from 2025-01-23 13-07-46
    After:
    Screenshot from 2025-01-23 13-08-14

  • I also fixed a flash of text that occurs on the /account_requests/new page, but didn't take a video of it. If you go to this page in production, you should see the flash I'm talking about though -> https://humanessentials.app/account_requests/new.

@coalest coalest changed the title Minor CSS fixes Minor CSS fixes to sign in/up flow Jan 23, 2025
Copy link
Collaborator

@dorner dorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tech review looks good - over to @cielf for functional.

@dorner dorner requested a review from cielf January 24, 2025 01:47
@cielf
Copy link
Collaborator

cielf commented Jan 24, 2025

LGTM

@cielf cielf merged commit a95b349 into rubyforgood:main Jan 24, 2025
11 checks passed
@coalest coalest deleted the css-fixes branch January 26, 2025 14:00
Copy link
Contributor

@coalest: Your PR Minor CSS fixes to sign in/up flow is part of today's Human Essentials production release: 2025.01.26.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants