-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce application.css file size #4944
Reduce application.css file size #4944
Conversation
@import 'bootstrap'; | ||
@import 'AdminLTE'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are removing the second AdminLTE import (from custom.scss
), we have to move this import after the bootstrap import. Because AdminLTE depends on and includes bootstrap 4.6 inside it's css, and we want bootstrap 4.6 to have priority over the other bootstrap (version 5.2).
@@ -53,15 +52,6 @@ | |||
} | |||
} | |||
|
|||
.wrapper-form-feedback { | |||
@extend .dropdown-item; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This @extend
call required the adminLTE import, but looks like we aren't using this wrapper-form-feedback
class anywhere so I went ahead and removed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK on my end.
I didn't check absolutely everything, but enough breadth and depth that I'm confident in this. |
@coalest: Your PR |
Description
I noticed our main CSS file is quite large (> 3 mb). Reducing it should improve browser performance.
This PR presents two changes:
@import 'AdminLTE'
repeated in two files. From the documentation:Type of change
How Has This Been Tested?
I did some side-by-side comparison with staging after the changes and everything looks the same to me. 🤷
Screenshots
Reduces the file size by about 2 megabytes in raw file size (160 kb over the wire).
Before:
After: