Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation widget #221

Closed
wants to merge 2 commits into from
Closed

Conversation

kruczjak
Copy link
Collaborator

@kruczjak kruczjak commented Jul 9, 2016

selection_277

It works like that: (using cookies)

  • row with suggested language will automatically show if there is different language selected in browser and this language is available
  • if someone clicked [dismiss], this row will never again appear
  • if someone clicks on language on row/change language in language selector, it will automatically redirect to page with correct language (when there is no such page, it will fallbacks to English)

I haven't found better place/look for language selector yet :/

It's based on redesign branch.

@kruczjak kruczjak mentioned this pull request Jul 9, 2016
2 tasks
@indirect indirect temporarily deployed to bundler-site-staging-pr-221 July 11, 2016 23:27 Inactive
@kruczjak kruczjak force-pushed the translation-widget branch from 3f5828e to eff9295 Compare July 11, 2016 23:41
@indirect indirect temporarily deployed to bundler-site-staging-pr-221 July 11, 2016 23:41 Inactive
@kruczjak kruczjak force-pushed the translation-widget branch from eff9295 to 24b7b45 Compare July 11, 2016 23:43
@indirect indirect temporarily deployed to bundler-site-staging-pr-221 July 11, 2016 23:43 Inactive
@kruczjak kruczjak force-pushed the translation-widget branch from 24b7b45 to dd5cf6b Compare July 20, 2016 18:04
@indirect indirect temporarily deployed to bundler-site-staging-pr-221 July 20, 2016 18:04 Inactive
@indirect
Copy link
Member

indirect commented Aug 1, 2016

@sailorhg when you have time, it would be great to get some input about the UX for translation options!

@bundlerbot
Copy link
Collaborator

☔ The latest upstream changes (presumably #309) made this pull request unmergeable. Please resolve the merge conflicts.

@colby-swandale
Copy link
Member

ping @indirect do we still want to merge this?

@esasse
Copy link
Collaborator

esasse commented Dec 13, 2019

This is now outdated and has conflicts. @kruczjak, do you still want to do this?

@duckinator
Copy link
Member

Given how out-of-date this PR is, I'm leaning towards closing this PR and opening a pair of issues to replace it (with a link to this one):

  1. An issue about adding a language selection drop-down.
  2. An issue about guessing based on what the browser indicates (blocked by the first one).

@deivid-rodriguez
Copy link
Member

Closing as suggested!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants