Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Spanish guides to catch up with latest changes #641

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

deivid-rodriguez
Copy link
Member

What was the end-user problem that led to this PR?

The problem was these guides were not updated in recent versions.

What is your fix for the problem, implemented in this PR?

My fix to adapt the changes applied to the English guides to these translated guides, so they are available to at https://bundler.io/es/v2.3/guides/bundler_setup.html and https://bundler.io/es/v2.3/guides/bundler_setup.html
and https://bundler.io/es/v2.3/guides/bundler_sharing.html.

--- source/localizable/v1.15/guides/bundler_setup.es.html.haml	2022-07-06 11:16:59.000000000 +0200
+++ source/localizable/v2.3/guides/bundler_setup.es.html.haml	2022-07-06 11:17:30.000000000 +0200
@@ -3,7 +3,7 @@
 ---
 
 .container.guide
-  %h2 Configurando Bundler
+  %h2 Cómo usar Bundler con Ruby
 
   .contents
     .bullet
@@ -96,7 +96,7 @@
           source 'https://rubygems.org'
 
           gem 'rails', '5.0.0'
-          gem 'rack-cache', :require => 'rack/cache'
+          gem 'rack-cache', require: 'rack/cache'
           gem 'nokogiri', '~> 1.4.2'
       .bullet
         .description
--- source/localizable/v1.15/guides/bundler_sharing.es.html.haml	2022-07-06 11:16:59.000000000 +0200
+++ source/localizable/v2.3/guides/bundler_sharing.es.html.haml	2022-07-06 11:17:31.000000000 +0200
@@ -3,7 +3,7 @@
 ---
 .container.guide
   %h2#sharing
-    Compartiendo su código
+    Cómo paquetizar y compartir código usando un Gemfile
   .contents
     .bullet
       .description
@@ -55,7 +55,7 @@
         En otras palabras, no va a adivinar cuales versiones de las dependencias debería
         instalar. En los ejemplos que hemos usado, aunque <code>rack-cache</code> declara una
         dependencia en <code>rack >= 0.4</code>, sabemos que definitivamente trabaja con <code>rack
-        1.2.1</code>. Aunque Rack lanzaría <code>rack 1.2.2</code>, bundler va a siempre instalar
-        <code>1.2.1</code>, la version exácta de la gema que sabemos que funciona. Esto
+        1.5.2</code>. Aunque Rack lanzaría <code>rack 1.5.3</code>, bundler va a siempre instalar
+        <code>1.5.2</code>, la version exácta de la gema que sabemos que funciona. Esto
         alivia una gran parte de la carga de mantenimiento de desarrolladores de aplicación, porque
         todas las máquinas siempre ejecutarán el mismo código de terceros.

Why did you choose this fix out of the possible options?

I chose this fix because regardless of whether these guides are actually useful for anyone or well translated, I think this unblocks further improvements to unify guides and make them not dependent on the bundler version.

@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-spanish-ldbp2e1tj July 6, 2022 09:24 Inactive
@tnir
Copy link
Collaborator

tnir commented Jul 6, 2022

In my mind, there is a plan to make all guides without copying es from 1.15 to 2.3 after #625 is merged. That plan does not need this change (#641).

@deivid-rodriguez
Copy link
Member Author

deivid-rodriguez commented Jul 6, 2022

Ok, let me check we're on the same page:

Your proposal

  • Make 1.12-15 redirect to 1.15 version of guides.
  • Make 1.16-2.3 redirect to 2.3 version of guides.
  • So, keep two copies of each guide.

My proposal

  • Make all guides redirect to the latest version of each guide.
  • So, keep one copy of each guide.

I thought you said that if we go with my idea, we "lose" the Spanish guides because they were not updated so the old versions would be lost. That's why I updated them, so that we can go with my solution next.

@deivid-rodriguez
Copy link
Member Author

I think we can move this forward now, and I think after this we're ready to also remove the 1.15 versions of guides, and move every guide to urls that are not dependent on versions.

It just applies the same changes applied to English guides to Spanish
translations.
@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-spanish-ldbp2e1tj July 6, 2022 18:05 Inactive
@deivid-rodriguez deivid-rodriguez merged commit 0ed466d into master Jul 6, 2022
@deivid-rodriguez deivid-rodriguez deleted the spanish branch July 6, 2022 18:20
@tnir
Copy link
Collaborator

tnir commented Jul 6, 2022

Yes, we can do it either way and I was fine either way. I will do the next step on top of this 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants