Remove jQuery dependency from search #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
temporarily deployed
to
bundler-site-tnir-remov-0nkjic
tnir
force-pushed
the
tnir-remove-jquery-from-search
branch
from
3ae4fb7 to
fc7f99a
Compare
deivid-rodriguez
temporarily deployed
to
bundler-site-tnir-remov-0nkjic
tnir
force-pushed
the
tnir-remove-jquery-from-search
branch
from
fc7f99a to
a5e27ab
Compare
deivid-rodriguez
temporarily deployed
to
bundler-site-tnir-remov-0nkjic
|
We can improve this after #644 merged. |
tnir
force-pushed
the
tnir-remove-jquery-from-search
branch
from
a5e27ab to
a1560af
Compare
deivid-rodriguez
temporarily deployed
to
bundler-site-tnir-remov-0nkjic
tnir
force-pushed
the
tnir-remove-jquery-from-search
branch
from
a1560af to
b86a89e
Compare
deivid-rodriguez
temporarily deployed
to
bundler-site-tnir-remov-0nkjic
tnir
force-pushed
the
tnir-remove-jquery-from-search
branch
from
b86a89e to
96f8d68
Compare
deivid-rodriguez
temporarily deployed
to
bundler-site-tnir-remov-0nkjic
tnir
force-pushed
the
tnir-remove-jquery-from-search
branch
from
96f8d68 to
a6f19d6
Compare
deivid-rodriguez
temporarily deployed
to
bundler-site-tnir-remov-0nkjic
Signed-off-by: Takuya Noguchi <[email protected]>
tnir
force-pushed
the
tnir-remove-jquery-from-search
branch
from
a6f19d6 to
565555b
Compare
deivid-rodriguez
temporarily deployed
to
bundler-site-tnir-remov-0nkjic
|
Thanks. Merging. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
An end-user has loaded unused jQuery.
What was your diagnosis of the problem?
These code currently depending on jQuery can be replaced with vanilla JS.
What is your fix for the problem, implemented in this PR?
The relevant code was simply replaced with vanilla JS.
Why did you choose this fix out of the possible options?
It was found difficult as
search.jshas Popper.js v1 dependency.Signed-off-by: Takuya Noguchi [email protected]