This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
[CLI] Dont reset every time the CLI is initialized #5504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is particularly hard to write a spec for since it depends on default gems who's source is the the ruby stdlib dir... ideas are welcome |
|
@indirect @colby-swandale any idea how to test this? |
|
@segiddins can we maybe look in the ruby stdlib dir for a json file and only run the test (against the json gem) if it's there? |
segiddins
force-pushed
the
seg-double-bundle-exec
branch
from
b8943da to
a58bda0
Compare
|
Sorry 😞 I'm still learning about Bundler's internals and I'm not sure how i would go testing this myself. |
|
It's OK, I managed to get a test working 😄 |
|
@indirect r? |
|
looks good! @bundlerbot r+ |
|
📌 Commit a58bda0 has been approved by |
bundlerbot
added a commit
that referenced
this pull request
Mar 15, 2017
[CLI] Dont reset every time the CLI is initialized Fixes #5500 - [x] Tests
|
☀️ Test successful - status-travis |
|
Thanks, @segiddins! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5500