This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Allow bundle install --force to work with git specs #5680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. Can you expand the PR description a bit to explain the why behind this PR? Based on the linked ticket it seems like using |
|
Description updated, the first commit was reverted because it was wrong and broke other things, I can rebase it away if you like. |
colby-swandale
approved these changes
May 29, 2017
segiddins
force-pushed
the
seg-git-force-no-git-ops
branch
from
dad4f4d to
5161573
Compare
|
Rebased |
colby-swandale
approved these changes
Jun 1, 2017
|
@bundlerbot r+ |
|
📌 Commit 5161573 has been approved by |
bundlerbot
added a commit
that referenced
this pull request
Jun 1, 2017
Allow bundle install --force to work with git specs This allows `bundle install --force` to work when the gemfile includes a git spec, previously it would error nonsensically. This happened because sources needed to be `remote!`ed for installation to succeed, and this wouldn't happen when `--force` was called with no other changes to the gemfile. Closes #5678
|
☀️ Test successful - status-travis |
segiddins
pushed a commit
that referenced
this pull request
Jun 2, 2017
Allow bundle install --force to work with git specs This allows `bundle install --force` to work when the gemfile includes a git spec, previously it would error nonsensically. This happened because sources needed to be `remote!`ed for installation to succeed, and this wouldn't happen when `--force` was called with no other changes to the gemfile. Closes #5678 (cherry picked from commit 7f1411c)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
bundle install --forceto work when the gemfile includes a git spec, previously it would error nonsensically. This happened because sources needed to beremote!ed for installation to succeed, and this wouldn't happen when--forcewas called with no other changes to the gemfile.Closes #5678