Suppress deprecation warnings in production code #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olleolleolle
approved these changes
Sep 4, 2017
koic
force-pushed
the
suppress_deprecation_warnings_in_production_code
branch
from
918fdcf to
827a3a8
Compare
|
Thanks for the review. I learned that |
|
@bundlerbot retry |
|
@bundlerbot r+ |
|
📌 Commit 827a3a8 has been approved by |
bundlerbot
added a commit
that referenced
this pull request
Sep 4, 2017
…_code, r=olleolleolle Suppress deprecation warnings in production code This PR suppresses the following Ruby warnings in production codes. -⚠️ `warning: URI.unescape is obsolete` -⚠️ `warning: URI.regexp is obsolete` -⚠️ `warning: instance variable @properties not initialized`
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suppresses the following Ruby warnings in production codes.
warning: URI.unescape is obsoletewarning: URI.regexp is obsoletewarning: instance variable @properties not initialized