Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the rubocop group across 1 directory with 2 updates #5405

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 23, 2025

Bumps the rubocop group with 2 updates in the / directory: rubocop and rubocop-rails.

Updates rubocop from 1.70.0 to 1.71.0

Changelog

Sourced from rubocop's changelog.

1.71.0 (2025-01-22)

New features

Bug fixes

  • #13684: Fix a false positive for Style/FrozenStringLiteralComment when using the frozen string literal magic comment in Active Admin's arb files. ([@​koic][])
  • #13372: Add rubocop_cache to the path given by --cache-root when pruning cache. ([@​capncavedan][])
  • #13257: Fix department disable/enable comments enabling the cop for the whole file even if that file is excluded by the cop. ([@​earlopain][])
  • #13704: Fix false positives for Lint/OutOfRangeRegexpRef when matching with match using safe navigation. ([@​koic][])
  • #13720: Fix false positives for Style/BlockDelimiters when using brace blocks as conditions under EnforcedStyle: semantic. ([@​koic][])
  • #13688: Fix false negative on Style/RedundantLineContinuation when the continuation is preceded by an interpolated string. ([@​dvandersluis][])
  • #13677: Fix false negative on Style/RedundantLineContinuation when the continuation is followed by a percent array. ([@​dvandersluis][])
  • #13692: Fix false positive in Style/RedundantLineContinuation when the ruby code ends with a commented continuation. ([@​dvandersluis][])
  • #13675: Fix invalid autocorrect for Style/ArrayFirstLast when calling .[] or &.[] with 0 or -1. ([@​dvandersluis][])
  • #13685: Fix syntax error introduced by Lint/SafeNavigationChain when adding safe navigation to an operator call inside a hash. ([@​dvandersluis][])
  • #13725: Fix an incorrect autocorrect for Style/IfUnlessModifier when using omitted hash values in an assignment. ([@​elliottt][])
  • #13667: Maintain precedence in autocorrect for Style/SoleNestedConditional. ([@​tejasbubane][])
  • #13679: Fix false positive for Style/RedundantLineContinuation when calling methods with fully qualified constants. ([@​earlopain][])
  • #13728: Fix a RuboCop error on provided glob pattern which matches directory. ([@​viralpraxis][])
  • #13693: Fix Style/ConditionalAssignment cop error on unless without else and assign_inside_condition enforced style. ([@​viralpraxis][])
  • #13669: Fix Style/FrozenStringLiteralComment cop error on unnormalized magic comment and never enforced style. ([@​viralpraxis][])
  • #13696: Update Metrics/CollectionLiteralLength to only register for [] when called on Set. ([@​dvandersluis][])

Changes

Commits
  • 6b13abb Cut 1.71
  • c923a84 Update Changelog
  • 83958cb Rename c_send to csend for consistency
  • 1f25c2c Add new InternalAffairs/OnSendWithoutOnCSend cop
  • 95f45cc [Fix #13323] Add new Lint/ArrayLiteralInRegexp cop
  • 30c4e20 Update Lint/LiteralInInterpolation to not handle array literals inside a re...
  • 7edf6d7 [Doc] Move rubocop-i18n from puppetlabs to rubocop org
  • c746991 Merge pull request #13737 from dvandersluis/fix-jruby-ci
  • b3c8061 Fix jruby CI error
  • 617fd40 Merge pull request #13734 from dvandersluis/fix-expect-offense
  • Additional commits viewable in compare view

Updates rubocop-rails from 2.28.0 to 2.29.0

Release notes

Sourced from rubocop-rails's releases.

RuboCop Rails 2.29.0

New features

Bug fixes

  • #1409: Fix an error for Rails/ReversibleMigration when calling drop_table without any arguments. (@​earlopain)
  • #1397: Fix an incorrect autocorrect for Rails/TimeZone when Time.new has a string argument. (@​mterada1228)
  • #1406: Fix autocorrection for Rails/IndexBy and Rails/IndexWith when map { ... }.to_h is enclosed in another block. (@​franzliedke, @​eugeneius)
  • #1404: Update Rails/IndexBy and Rails/IndexWith to support numbered block parameters. (@​eugeneius)
  • #1405: Fix autocorrection for Rails/IndexWith when the value is a hash literal without braces. (@​koic, @​eugeneius)
  • #1414: Fix Rails/HttpPositionalArguments cop false positives with arguments forwarding. (@​viralpraxis)

Changes

  • #1410: Make registered cops aware of AllCops: MigratedSchemaVersion. (@​koic)
Changelog

Sourced from rubocop-rails's changelog.

2.29.0 (2025-01-18)

New features

Bug fixes

  • #1409: Fix an error for Rails/ReversibleMigration when calling drop_table without any arguments. ([@​earlopain][])
  • #1397: Fix an incorrect autocorrect for Rails/TimeZone when Time.new has a string argument. ([@​mterada1228][])
  • #1406: Fix autocorrection for Rails/IndexBy and Rails/IndexWith when map { ... }.to_h is enclosed in another block. ([@​franzliedke][], [@​eugeneius][])
  • #1404: Update Rails/IndexBy and Rails/IndexWith to support numbered block parameters. ([@​eugeneius][])
  • #1405: Fix autocorrection for Rails/IndexWith when the value is a hash literal without braces. ([@​koic][], [@​eugeneius][])
  • #1414: Fix Rails/HttpPositionalArguments cop false positives with arguments forwarding. ([@​viralpraxis][])

Changes

  • #1410: Make registered cops aware of AllCops: MigratedSchemaVersion. ([@​koic][])
Commits
  • 983f264 Cut 2.29.0
  • 72a9281 Update Changelog
  • 047dee3 Merge pull request #1414 from viralpraxis/fix-rails-http-positional-arguments...
  • 1c4c37e Merge pull request #1412 from koic/add_new_rails_strong_parameters_expect_cop
  • ffdcd44 Merge pull request #1411 from koic/make_registered_cops_aware_of_all_cops_mig...
  • d47284e Fix Rails/HttpPositionalArguments cop false positives with arguments forwar...
  • 2d6daa3 Add new Rails/StrongParametersExpect cop
  • 4e4b1e6 Add missing Include paths for Rails/MultipleRoutePaths
  • 4214608 [Fix #1410] Make registered cops aware of AllCops: MigratedSchemaVersion
  • b1fbd49 Merge pull request #1407 from koic/add_new_rails_multiple_route_paths_cop
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Jan 23, 2025
@segiddins segiddins enabled auto-merge (squash) January 23, 2025 16:16
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.06%. Comparing base (3b8afdb) to head (3576a76).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5405   +/-   ##
=======================================
  Coverage   97.06%   97.06%           
=======================================
  Files         451      451           
  Lines        9391     9391           
=======================================
  Hits         9115     9115           
  Misses        276      276           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dependabot bot and others added 3 commits January 23, 2025 11:13
Bumps the rubocop group with 2 updates in the / directory: [rubocop](https://github.com/rubocop/rubocop) and [rubocop-rails](https://github.com/rubocop/rubocop-rails).


Updates `rubocop` from 1.70.0 to 1.71.0
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.70.0...v1.71.0)

Updates `rubocop-rails` from 2.28.0 to 2.29.0
- [Release notes](https://github.com/rubocop/rubocop-rails/releases)
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rails@v2.28.0...v2.29.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: rubocop
- dependency-name: rubocop-rails
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: rubocop
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Samuel Giddins <[email protected]>
@martinemde martinemde force-pushed the dependabot/bundler/rubocop-ce735641b2 branch from 149fde5 to 3576a76 Compare January 23, 2025 19:13
@segiddins segiddins merged commit 06c4e98 into master Jan 23, 2025
19 checks passed
@segiddins segiddins deleted the dependabot/bundler/rubocop-ce735641b2 branch January 23, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
Development

Successfully merging this pull request may close these issues.

2 participants