Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

Explore possibility of MinGW Support #126

Closed
ignisf opened this issue Jun 17, 2014 · 14 comments
Closed

Explore possibility of MinGW Support #126

ignisf opened this issue Jun 17, 2014 · 14 comments

Comments

@ignisf
Copy link
Collaborator

ignisf commented Jun 17, 2014

It seems that v8 has some not-officially-supported-but-documented upstream support for mingw32 now.

https://code.google.com/p/v8/wiki/BuildingWithGYP#MinGW

This needs to be checked in order to provide Windows support

@ignisf ignisf added this to the 3.27 milestone Jun 17, 2014
@ignisf ignisf self-assigned this Jun 17, 2014
@ignisf ignisf added the feature label Jun 17, 2014
@ignisf ignisf changed the title MingW Support MinGW Support Jun 17, 2014
@ignisf ignisf changed the title MinGW Support Explore possibility of MinGW Support Jun 17, 2014
@ignisf
Copy link
Collaborator Author

ignisf commented Aug 29, 2014

cc @jake-bladt

@ignisf ignisf mentioned this issue Sep 3, 2014
@ignisf ignisf removed their assignment Sep 3, 2014
@ignisf ignisf modified the milestones: trunk, 3.27 Nov 16, 2014
@ignisf
Copy link
Collaborator Author

ignisf commented Mar 20, 2015

cc @stormbreakerbg

@ignisf
Copy link
Collaborator Author

ignisf commented Mar 23, 2015

@jarredholman
Copy link
Contributor

I pretty much have this working now https://github.com/jarredholman/libv8/tree/mingw

I'm not sure what the process for pull request/reviews is here... there is both master and trunk, and I had to include some other changes because master was broken thanks to the "rc1" in the version.

@ignisf
Copy link
Collaborator Author

ignisf commented Apr 4, 2015

That looks great!
Can you open up a PR for each branch?

@jarredholman
Copy link
Contributor

So what is trunk for? A somewhat never version of v8 (but still quite outdated?)?

@ignisf
Copy link
Collaborator Author

ignisf commented Apr 4, 2015

Whenever therubyracer gets ported to compile against the trunk version of libv8, I'll replace the current master branch with this trunk and will try to keep it up to date.

Unfortunately an effort to update therubyracer has started only recently and I haven't been keeping the trunk branch up to date.

@jarredholman
Copy link
Contributor

trunk is going to be more difficult since icu is a dependency there. This might take a bit longer.

@ignisf
Copy link
Collaborator Author

ignisf commented Apr 4, 2015

I thought I explicitly disabled ICU with this line https://github.com/cowboyd/libv8/blob/trunk/ext/libv8/builder.rb#L34
Is this not the case?

@ignisf
Copy link
Collaborator Author

ignisf commented Apr 8, 2015

Resolved by #166

@ignisf ignisf closed this as completed Apr 8, 2015
@jarredholman
Copy link
Contributor

I'm still working on this for trunk as well. Somehow it is much more difficult.

@ignisf
Copy link
Collaborator Author

ignisf commented Apr 9, 2015

@jarredholman, trunk-rebase contains the trunk branch rebased on the changes in master. What seems to be the hold up? ICU?

@jarredholman
Copy link
Contributor

Got past the ICU issue, but then ran into problems during the compile. Slowly getting there as I fix each issue.

So far I have had to add -std=c++11 to the compile flags (not sure how the Linux version builds without it) and fixed the order of includes in one of the source file.

Its currently stuck trying to build the "host" version of the tool because it apparently ignores the target cxxflags you provide. I should probably just get the ia32 version working first...

@ignisf
Copy link
Collaborator Author

ignisf commented Apr 10, 2015

If you think that this issue has been fixed in newer versions of v8, we should update and not waste time on it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants