Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

Added support for windows platforms using mingw. #166

Merged
merged 4 commits into from
Apr 8, 2015
Merged

Added support for windows platforms using mingw. #166

merged 4 commits into from
Apr 8, 2015

Conversation

jarredholman
Copy link
Contributor

Adds windows support using mingw compiler that comes with rubyinstaller's devkit.

Also requires Python27 (official windows build) and msysgit.

To build, open cmd.exe shell

set PATH=%PATH%;C:\Python27;C:\Program Files (x86)\Git\bin
c:\ruby-devkit-mingw64\devkitvars.bat
bundle install
bundle exec rake compile

mingw-generate-makefiles.sh script is a modified version from v8 source (modification just adds x64 target).

@cowboyd
Copy link
Collaborator

cowboyd commented Apr 7, 2015

Are there any hosted CI solutions that support windows builds?

@ignisf
Copy link
Collaborator

ignisf commented Apr 7, 2015

I don't believe I've heard of any

@jarredholman
Copy link
Contributor Author

Could try http://www.appveyor.com/ ?

@cowboyd
Copy link
Collaborator

cowboyd commented Apr 8, 2015

Looks promising. I've set up a project there to build libv8 https://ci.appveyor.com/project/cowboyd/libv8

but it looks like it needs an appveyor.yml to get working. It should build pull requests, if you have any experience with appveyor, it would be awesome if you could submit one to get it working :)

@jarredholman
Copy link
Contributor Author

I haven't used it before but it doesn't look too hard so I'll have a go at it.

Let make output directly to stdout instead of capturing.
@jarredholman
Copy link
Contributor Author

Added a first attempt. I only really tested that it worked for ruby21-x64 but I've enabled all the ruby versions to see what happens.

There is one slight problem. It rebuilds v8_base again for the "host" after doing it for the "target" so that it can run "tools_gyp_v8_gyp_js2c_host_js2c".
This is making the build get dangerously close to the 30 minute time limit.

I looked at the Travis CI log and it seems like the linux build doesn't do that so I'm not sure why this would be different.

@jarredholman
Copy link
Contributor Author

Seems like the time was not as bad as I thought...

@cowboyd
Copy link
Collaborator

cowboyd commented Apr 8, 2015

Whoa, that was easy. If you're ok with this @ignisf, let's merge it.

ignisf added a commit that referenced this pull request Apr 8, 2015
Added support for windows platforms using mingw.
@ignisf ignisf merged commit d00f9f2 into rubyjs:master Apr 8, 2015
@jarredholman jarredholman deleted the mingw branch April 9, 2015 02:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants