Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

Add patch for clang 7.3 (-Wshift-negative-value) #206

Closed
wants to merge 1 commit into from

Conversation

burke
Copy link

@burke burke commented Mar 22, 2016

This fixes gem install for me on OS X 10.11.4, XCode 7.3, clang 7.3.

Resolves #205

@aviat
Copy link
Contributor

aviat commented Apr 24, 2016

@burke I saw your PR a bit late after I made #207 - basically the same thing, but patching options passed to clang, disabling -Wshift-negative-value, instead of patching V8. It seems simpler and more reliable to me. Furthremore, similar issues was already handled in this way (check all the clang* directories under libv8/patches).
What do you think about that?

@ignisf
Copy link
Collaborator

ignisf commented Apr 24, 2016

This should no longer be necessary due to #207 being merged. Please test.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libv8 fails to compile with OS X 10.11.4/Xcode 7.3/clang 7.3.0
3 participants