-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMS: probe checking the number and volume of rules per rse, activity and state #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eachristgr
added a commit
to eachristgr/CMSRucio
that referenced
this pull request
Nov 11, 2024
eachristgr
added a commit
to eachristgr/CMSRucio
that referenced
this pull request
Nov 11, 2024
ericvaandering
requested changes
Nov 27, 2024
ericvaandering
added a commit
to dmwm/CMSRucio
that referenced
this pull request
Nov 27, 2024
ericvaandering
requested changes
Dec 2, 2024
eachristgr
force-pushed
the
cms-rules-volume
branch
from
December 3, 2024 10:36
2ee25a9
to
592c59a
Compare
Changes were applied in favor of readability and commits were squashed to ensure a cleaner merge. |
ericvaandering
requested changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, two more changes.
- Please put a newline at the very end
- The commit has to be renamed to designate CMS: "The subject of each commit must be prefixed by a label. This can be omitted for rare changes across the entire repository. If there is an issue related to the commit, then its number should be appended. For example, a commit may resemble this: ATLAS: Port probes to Python 3 #1234" per the Contributing.md file
eachristgr
force-pushed
the
cms-rules-volume
branch
from
December 3, 2024 17:00
592c59a
to
94b72e2
Compare
Changes applied. Hope the commit message looks good as well. |
Thanks! |
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to dmwm/CMSRucio#747
The script acts on rules with the following states:
OK
REPLICATING
STUCK
The script pushes the following metrics by using
PrometheusPusher
:rule_count_per_rse_activity_state
: The number of rules perrse
,activity
andstate
rule_volume_per_rse_activity_state
: The total size (in bytes) of rules perrse
,activity
andstate
Tested it on Integration and it works as far as I can see.
More details about the implementation are commented in the script.
FYI @haozturk