-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: address snyk vulnerabilities #2579
Conversation
Codecov ReportBase: 44.08% // Head: 44.04% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2579 +/- ##
==========================================
- Coverage 44.08% 44.04% -0.05%
==========================================
Files 187 187
Lines 39255 39255
==========================================
- Hits 17305 17288 -17
- Misses 20845 20862 +17
Partials 1105 1105
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's check with server team for this as well.
cd7b3d6
to
56a8894
Compare
3df2e97
to
245256d
Compare
c48a910
to
568c073
Compare
b9439d3
to
6b3527b
Compare
"fmt" | ||
"io" | ||
"log" | ||
"net/http" | ||
"strconv" | ||
"time" | ||
|
||
"github.com/buger/jsonparser" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
buger/jsonparser
was conflicting with migrate library, it was preventing the upgrade of migrate library.
Since we could easily use json.Unmarshal
to parse it I've removed it as a dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor comment with regards to replacements
@@ -2,9 +2,20 @@ module github.com/rudderlabs/rudder-server | |||
|
|||
go 1.18 | |||
|
|||
replace ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be useful to add a comment here to remind us that at some point, once we upgrade the relevant libraries, these replacements can become outdated and should be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, eventually, we should do that, and we also need to keep the replacement versions up to date.
I am not fun of replace
solution, and I tried to use it as little as possible. I am considering ways we can avoid it or make it easier to maintain.
Co-authored-by: chandumlg <[email protected]>
…dder-server into fix.snyk_vul_rudder_server
Description
With the changes of this PR contains and ignoring vulnerabilities not applicable to us (etcd server mostly), we reached to zero:
How
Notion Ticket
https://www.notion.so/rudderstacks/rudder-server-snyk-vulnerabilities-56d33002b9c54385abbfed434124a43f
Security