-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fixing a flaky rsources test #2680
Conversation
Codecov ReportBase: 45.51% // Head: 45.47% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2680 +/- ##
==========================================
- Coverage 45.51% 45.47% -0.05%
==========================================
Files 289 290 +1
Lines 48007 48028 +21
==========================================
- Hits 21852 21841 -11
- Misses 24775 24804 +29
- Partials 1380 1383 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
81bf86b
to
136fd16
Compare
24d5a1b
to
e6c05ab
Compare
ce174ad
to
5e56f37
Compare
c16187f
to
92cad02
Compare
0068653
to
4e3a11d
Compare
4e3a11d
to
9bd67a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't just transaction removal sufficient. Why remove if exists
?
|
Description
Resolved 3 issues with the flaky tests:
if exists
clauses fromcreate table
, since it could lead to tables not being created in some scenarios, e.g. 2 concurrent transactions, 1st creates the table, 2nd skips, then 1st does a Tx rollback so table is not created.Ordered
Ginkgo containers andBeforeAll
which caused containers to be reused beyond the desired boundaries.Security