Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(warehouse): use correct config for columns batch size #2720

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

achettyiitr
Copy link
Member

Description

  • We are using the wrong config for columnsBatchSize as customDatasetPrefix.
  • Also we don't need to log the load files information for BiqQuery. It is polluting the logs.

Notion Ticket

https://www.notion.so/rudderstacks/Use-batching-to-run-several-of-alter-statements-81ae26d5db6f4b2ca8e0258e3ce0cba6

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 45.85% // Head: 45.86% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (ae5b931) compared to base (712b6a5).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2720      +/-   ##
==========================================
+ Coverage   45.85%   45.86%   +0.01%     
==========================================
  Files         295      295              
  Lines       48499    48499              
==========================================
+ Hits        22239    22244       +5     
+ Misses      24857    24853       -4     
+ Partials     1403     1402       -1     
Impacted Files Coverage Δ
warehouse/bigquery/bigquery.go 1.12% <0.00%> (ø)
warehouse/upload.go 18.45% <0.00%> (ø)
config/backend-config/namespace_config.go 67.00% <0.00%> (-3.00%) ⬇️
processor/processor.go 86.40% <0.00%> (+0.41%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants