fix(warehouse): increase async job timeout #2721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achettyiitr
changed the title
Jayachand
approved these changes
Nov 23, 2022
lvrach
reviewed
Nov 23, 2022
| @@ -91,5 +91,5 @@ const ( | |||
| MaxQueryRetries int = 3 | |||
| RetryTimeInterval = 10 * time.Second | |||
| MaxAttemptsPerJob int = 3 | |||
| WhAsyncJobTimeOut = 10 * time.Second | |||
There was a problem hiding this comment.
Should we make this configurable? Is this the default value we are changing?
Codecov ReportBase: 46.38% // Head: 46.80% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2721 +/- ##
==========================================
+ Coverage 46.38% 46.80% +0.41%
==========================================
Files 295 297 +2
Lines 48610 48696 +86
==========================================
+ Hits 22550 22791 +241
+ Misses 24646 24477 -169
- Partials 1414 1428 +14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Jayachand
reviewed
Nov 24, 2022
| func (asyncWhJob *AsyncJobWhT) AddWarehouseJobHandler(w http.ResponseWriter, r *http.Request) { | ||
| pkgLogger.Info("[WH-Jobs] Got Async Job Add Request") | ||
| pkgLogger.LogRequest(r) | ||
| func (a *AsyncJobWhT) AddWarehouseJobHandler(w http.ResponseWriter, r *http.Request) { |
There was a problem hiding this comment.
a looks like too generic. rename to asyncJob ??
1 task
lvrach
approved these changes
Nov 24, 2022
This was referenced Dec 1, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AsyncJobWhTas a instead of asyncWhJob.AsyncJobWhTitself.Notion Ticket
https://www.notion.so/rudderstacks/Warehouse-Async-Job-Framework-Sync-79a575f429e540d79e9094651b30d7e8
Security