Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: airship mapping issue #3969

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Conversation

aanshi07
Copy link
Contributor

@aanshi07 aanshi07 commented Jan 8, 2025

What are the changes introduced in this PR?

Fixed the traits mapping issue with firstName, lastName and createdAt

What is the related Linear task?

Resolves INT-3089

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@aanshi07 aanshi07 self-assigned this Jan 8, 2025
@aanshi07 aanshi07 requested review from a team and sivashanmukh as code owners January 8, 2025 07:54
@aanshi07 aanshi07 changed the title fix.airship mapping issue fix: airship mapping issue Jan 8, 2025
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.81%. Comparing base (ba8ad19) to head (730617d).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3969      +/-   ##
===========================================
+ Coverage    90.78%   90.81%   +0.03%     
===========================================
  Files          624      626       +2     
  Lines        32553    32657     +104     
  Branches      7727     7747      +20     
===========================================
+ Hits         29552    29657     +105     
+ Misses        2777     2744      -33     
- Partials       224      256      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

ItsSudip
ItsSudip previously approved these changes Jan 8, 2025
@aanshi07 aanshi07 dismissed ItsSudip’s stale review January 8, 2025 09:36

The merge-base changed after approval.

@aanshi07 aanshi07 changed the base branch from develop to main January 8, 2025 10:19
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@sanpj2292 sanpj2292 changed the base branch from main to develop January 9, 2025 05:20
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants