-
-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement audio syncing for "stream" sounds #3958
Comments
Hi Mike. I am attaching an example file, it is somewhat long, but it also happens in other very short 2-3 seconds. thanks! |
This is a first pass at syncing animation and audio playback when and embedded audio stream is playing. Fixes ruffle-rs#3020, ruffle-rs#3663, ruffle-rs#3958.
Implemented in #5486. |
Playing a "Stream" sound on the timeline triggers frame-skipping behavior in the Flash Player to keep the animation in sync with the sound. Ruffle does not fully implement this.
Currently, Ruffle does frame-skipping at all times, which more-or-less keeps audio in sync for most cases. However, if the audio still manages to get out of sync (because the player or the audio stalls for some amount of time), there is no mechanism to re-sync the animation. This also occurs immediately in some exotic situations, such as when a stream sound is played in a loaded movie that has a different framerate from the root movie.
This should hopefully handle all of these cases:
run_frame_internal
to prevent audio stutter. Close #3817 #3819)I'm thinking something like this:
The text was updated successfully, but these errors were encountered: