[twice-regressed] Hebrew chars not displayed at all

[ousia]

Describe the bug

This comes from #5839.

https://github.com/ruffle-rs/ruffle/files/6273851/clock.zip should have chars displayed as:

#5839 was solved by #5900.

But using current nightly from 2022-12-21, Hebrew characters aren’t displayed at all:

Expected behavior

Hebrew characters should be displayed (ideally, R2L and not L2R [as already reported in #3921]).

Many thanks for your help.

Affected platform

Online demo

Operating system

Fedora 35

Browser

Firefox 107

Additional information

No response

[ousia]

Screenshot from browser (since I haven’t generated the Windows image myself):

[danielhjacobs]

You can try to find when it regressed using https://ruffle-regressions.github.io/.

If you don't, someone else probably will, though I'm busy right now.

Edit: Or do you mean it just regressed?

[ousia]

@danielhjacobs,

many thanks for the info on https://ruffle-regressions.github.io (I didn’t know there was such a site).
According to the images:

Nightly from 2022-09-08 seems to be the culprit:

So the code is nightly-2022-09-07...nightly-2022-09-08.

The only PR related to text seems to be #7853 (but I may be wrong here, since there seems to be no EditText in the SWF).

@dhtdht020, could you also confirm whether texts are displayed R2L? On Linux, texts seem to be the same.

Many thanks for your help.

[n0samu]

Looks like the characters are displayed incorrectly in the Linux Flash projector but correctly in the Windows Flash projector. Here's how the bottom-left text looks for me in the Windows projector:

[n0samu]

The only PR related to text seems to be #7853 (but I may be wrong here, since there seems to be no EditText in the SWF).

That is indeed correct - I've bisected the problem to commit 84481c2 of that PR. The SWF actually creates all of its text fields at runtime using createTextField.

[ousia]

@n0samu,

I get the same output with the Windows Flash projector using Wine in Linux.

Many thanks for your help.

[n0samu]

Hmm, well Wine has never worked well with non-English characters, in my experience.

[ousia]

My knowledge or other scripts (and languages) is limited to L2R.

So I didn’t know that Wine had problems with R2L.

[dhtdht020]

I can confirm this is still an issue as of Nightly 2023-09-08.

Could also replicate this exact issue on Linux through online demo on firefox, so does not seem platform-specific.

@dhtdht020, could you also confirm whether texts are displayed R2L? On Linux, texts seem to be the same.

@ousia Sorry for not responding, GitHub did not notify me about the mention. The text in the Flash Player running under wine is displayed in the wrong order similarly to the problem presented in #3921, unlike Flash Player running on a proper Windows installation which displays the text correctly.

[n0samu]

After looking more into this, it unfortunately seems to be expected behavior, not a bug. The SWF contains an Arial font with all of the needed characters, but does not actually use the embedded font. It only works in Flash Player because it is able to load the Arial font installed on the user's device. Now that #14535 was merged, it works in the desktop app, at least. To work on the web, either the code would need to be modified, or a second SWF containing the required font would need to be created and Ruffle would need to be configured to use it. See the FAQ for instructions.

[ousia]

@n0samu, is there no way for the web to load device fonts, such as the desktop app does?

[n0samu]

Yes, currently the web environment does not support loading fonts from the user's device.