text: Use bitflags for edit text flags #7853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Herschel
force-pushed
the
swf-edit-text-flags
branch
2 times, most recently
from
570108b to
7997c7c
Compare
relrelb
reviewed
Sep 3, 2022
relrelb
reviewed
Sep 3, 2022
relrelb
reviewed
Sep 3, 2022
Herschel
force-pushed
the
swf-edit-text-flags
branch
3 times, most recently
from
cd702a2 to
3913b51
Compare
Herschel
force-pushed
the
swf-edit-text-flags
branch
from
3913b51 to
2f32023
Compare
Herschel
force-pushed
the
swf-edit-text-flags
branch
from
2f32023 to
cf3905a
Compare
relrelb
approved these changes
Sep 6, 2022
relrelb
reviewed
Sep 6, 2022
|
|
||
| /// If the text field should have a background. Only applied when has_border. | ||
| has_background: bool, | ||
|
|
||
| /// The color of the background fill. Only applied when has_border and has_background. | ||
| background_color: u32, |
There was a problem hiding this comment.
I think background_color and border_color should be swf::Color, but that's for a future PR.
The SWF19 specs incorrectly state DefineEditText tag only contains font height if the HasFont flag is set. The tag also contains the height if the HasFontClass flag is set. This indicates that a font is used via runtime sharing.
Herschel
force-pushed
the
swf-edit-text-flags
branch
from
cf3905a to
f9bd2ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the massive set of bools used by
swf::EditTextandcore::edit_text::EditText.swf::EditTextFlagfor the bits used by the DefineEditText SWF tag.swf::EditTextto allow setting these flags and values.core::edit_text::EditTextFlagthat extends this with additional flags used by core/ActionScript.EditTextStaticas it was mostly unused fields.HAS_FONT_CLASSflag is set.Shaves off 8 bytes or so from
EditText. This is a small step to make #7749 nicer.