Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Select "desktop" as the default workspace member #10609

Merged
merged 3 commits into from
Apr 9, 2023

Conversation

torokati44
Copy link
Member

This makes the cargo command to run the player simpler:
$ cargo run stuff.swf

Instead of:
$ cargo run --bin ruffle_desktop -- stuff.swf

See: rust-lang/cargo#7290

@torokati44
Copy link
Member Author

The downside is that cargo test now needs to be invoked with --all added...

@Herschel
Copy link
Member

Herschel commented Apr 8, 2023

The downside is that cargo test now needs to be invoked with --all added...

I was in the habit of always running with --all anyway, because usually my terminal is in some subfolder of the workspace.

@Herschel
Copy link
Member

Herschel commented Apr 8, 2023

Do we need to update any docs to make sure cargo test --all is spelled out?

@Herschel Herschel force-pushed the default-members-desktop branch from e20097b to 4c00711 Compare April 9, 2023 19:11
Copy link
Member

@Herschel Herschel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like only CONTRIBUTING.md mentioned it, I tossed an --all in there for good measure. Thank you!

@Herschel Herschel force-pushed the default-members-desktop branch from 4c00711 to 65f5128 Compare April 9, 2023 19:12
@Herschel Herschel enabled auto-merge (rebase) April 9, 2023 19:12
@Herschel Herschel merged commit 0380552 into ruffle-rs:master Apr 9, 2023
@torokati44
Copy link
Member Author

Looks like only CONTRIBUTING.md mentioned it, I tossed an --all in there for good measure.

Yeah, that's the only relevant piece of doc' that I found too. Thanks for fixing it up! (I was doing Easter Family Stuff...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants