avm1: Improve loops treatment in Sound.start #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Herschel
reviewed
Dec 6, 2020
|
Thanks for splitting this out into a separate PR! I guess we should verify if the loops count can actually be an |
Herschel
reviewed
Dec 6, 2020
The second argument of Sound.start, loops, can be greater than std::u16::MAX, but previously greater values were treated as 1. Ideally, the solution is to respect those values, but since SoundInfo holds a u16, a short-term solution is to treat them as std::u16::MAX instead.
|
Fixed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second argument of
Sound.start,loops, can be greater thanstd::u16::MAX, but previously greater values were treated as 1.Ideally, the solution is to respect those values, but since
SoundInfoholds au16, a short-term solution is to treat them asstd::u16::MAXinstead.Extracted from #1445 since this commit is unrelated.