avm2: Fix EditText and Graphic linkage #18770
Conversation
Lord-McSweeney
force-pushed
the
edittext-graphic-fixes
branch
from
d747066 to
042aad1
Compare
| @@ -4554,7 +4557,9 @@ impl<'gc, 'a> MovieClip<'gc> { | |||
| .library | |||
| .library_for_movie_mut(movie.clone()); | |||
|
|
|||
| match library.character_by_id(id) { | |||
| let character = library.character_by_id(id); | |||
There was a problem hiding this comment.
This needs to be duplicated (here and in lookup_class_for_character) to satisfy the borrow checker
There was a problem hiding this comment.
I'm guessing Character should just become a Copy, if/when all its variants become Gc wrappers - that should solve it, right?
(not in this PR, I can try refactoring it as a followup)
| @@ -4554,7 +4557,9 @@ impl<'gc, 'a> MovieClip<'gc> { | |||
| .library | |||
| .library_for_movie_mut(movie.clone()); | |||
|
|
|||
| match library.character_by_id(id) { | |||
| let character = library.character_by_id(id); | |||
There was a problem hiding this comment.
I'm guessing Character should just become a Copy, if/when all its variants become Gc wrappers - that should solve it, right?
(not in this PR, I can try refactoring it as a followup)
|
Oh, and I think the first commit should move to the end, since you said it's technically broken without the refactor, right? |
|
(Could someone add a |
danielhjacobs
added
A-avm2
Lord-McSweeney
force-pushed
the
edittext-graphic-fixes
branch
2 times, most recently
from
1ec0562 to
9270fc6
Compare
Also ensure that any ClassObject linked to a DO extends `flash.display.DisplayObject`
This removes the `flash_events_internal` namespace from CommonNamespaces
Lord-McSweeney
force-pushed
the
edittext-graphic-fixes
branch
from
9270fc6 to
5a6880d
Compare
No description provided.