text: Improve EditText::maxscroll
#18783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
added
text
adrian17
approved these changes
Nov 27, 2024
This patch makes it more accurate by using text height and taking the gutter into account. This also makes text/links_in_scrolled_text pass.
This test verifies how the max scroll behaves depending on text field's height and text height.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes
EditText::maxscrollmore accurate by using text height and taking the gutter into account.This patch makes
text/links_in_scrolled_textpass (it was an accident, but I'll accept that as a success).A brute-force test for
TextField.maxScrollVdepending ontextHeightandheightis also added in order to make sure we're heading in the right direction here.TODO: this requires #18772 to work properly, otherwise
avm1/edittext_scrollfails.