avm1: Various Sound fixes #4026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Herschel
reviewed
Apr 16, 2021
Previously it returned 0.
Previously it was always rounded down. Change it to the nearest integer.
These seem to be undocumented. Looks like Sound.getDuration() behaves exactly as Sound.duration, and Sound.setDuration() does nothing.
Check Sound.duration and Sound.getDuration() for detached sounds. Check rounding behavior of Sound.duration and Sound.getDuration() behind a comment because NullAudioBackend doesn't respect durations. TODO: Uncomment it once NullAudioBackend returns real durations.
Herschel
approved these changes
Apr 17, 2021
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sound.durationshould returnundefinedwhen no sound is attached (fixes Sound duration and position works differently in Ruffle (AS2) #4010). Previously it returned 0.Sound.duration(also Sound duration and position works differently in Ruffle (AS2) #4010). Previously it was always rounded down. Change it to the nearest integer.Sound.getDurationandSound.setDuration.