core/mp3: More lenient MP3 buffer underrun detection #7816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd add a comment to the code that this is a quick fix and that we're not sure of the exact behavior. |
|
Sure, that's also part of why I marked it as draft. |
torokati44
force-pushed
the
mp3-decoder-underrun
branch
from
38481da to
59dcd64
Compare
|
I've added a little explainer comment for the change. |
torokati44
force-pushed
the
mp3-decoder-underrun
branch
from
59dcd64 to
dba31b4
Compare
|
Mainly checking that this change doesn't make things worse for any cases. If it's strictly an improvement or no change, then I think this is fine to merge. |
torokati44
force-pushed
the
mp3-decoder-underrun
branch
from
dba31b4 to
50551f1
Compare
torokati44
force-pushed
the
mp3-decoder-underrun
branch
from
50551f1 to
53d8121
Compare
Herschel
force-pushed
the
mp3-decoder-underrun
branch
from
53d8121 to
cb37718
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #7524.
Regression testing in progress, re: #5486 #6546
(Sorry for being so terse for now, I just had to get this out of my brain ASAP.)