Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback for git task #23

Merged
merged 4 commits into from
Jul 3, 2021
Merged

Add fallback for git task #23

merged 4 commits into from
Jul 3, 2021

Conversation

ruffsl
Copy link
Owner

@ruffsl ruffsl commented Jul 2, 2021

No description provided.

such as when a locked repo is rebased
and old commits are garbage collected
@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #23 (9258166) into master (443aa36) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   97.17%   97.18%   +0.01%     
==========================================
  Files          19       19              
  Lines         566      569       +3     
  Branches       79       79              
==========================================
+ Hits          550      553       +3     
  Misses          9        9              
  Partials        7        7              
Impacted Files Coverage Δ
colcon_cache/task/lock/git.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 443aa36...9258166. Read the comment docs.

and have it default to `HEAD`
so that the same behavior is kept
while being robust to git rebasing

users can set both reference revision and fallback to the same thing
if they would like the command to error for unresolvable references
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant