Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename EmojiOne to JoyPixels in the dropdown? #82

Closed
dmxt opened this issue Mar 4, 2020 · 5 comments
Closed

Rename EmojiOne to JoyPixels in the dropdown? #82

dmxt opened this issue Mar 4, 2020 · 5 comments
Labels
bug Something isn't working

Comments

@dmxt
Copy link

dmxt commented Mar 4, 2020

For skimmers: just bold text is important

Bug description

Set emoji-style dropdown (in the Firefox add-on option page) still have 'EmojiOne' as an option.

Wouldn't it be reasonable to rename EmojiOne to JoyPixels in the dropdown too?

EmojiOne recently got renamed to JoyPixels (referring to the README)

Steps to reproduce

  1. Open the Firefox add-on option page
  2. Click 'set' dropdown
  3. Examine the emoji name 'EmojiOne'

Actual behavior

Witness the name EmojiOne in the dropdown

Expected behavior

Witness the name JoyPixels in the dropdown

System

Operating system and version: Arch Linux x86_64 why? Btw the kernel is 5.57-arch1-1
Browser and version: Firefox 73.0.1 (64-bit)
Add-on version: 1.2 (last updated January 21, 2020)

Possible solution

Rename EmojiOne to JoyPixels in the dropdown

Footnote:

Some humor was included bc of answering the template questions for something trivial lol

@dmxt dmxt added the bug Something isn't working label Mar 4, 2020
@rugk
Copy link
Owner

rugk commented Mar 5, 2020

Hehe, well... in such an obvious case you could have skipped the non-essential parts of the template. 😄

Anyway, yes, that would be an idea. Actually, the included Emojis, however, still are the ones from EmojiOne, i.e. the old ones before it was renamed. That is due to legal reasons and the upstream, projects already have removed it, see iamcal/emoji-data#142.

@rugk
Copy link
Owner

rugk commented Mar 5, 2020

I just saw I have no issue for discussion EmojiOne/JoyPixels support in the future, so here is one: #83

@dmxt
Copy link
Author

dmxt commented Mar 9, 2020

I just saw I have no issue for discussion EmojiOne/JoyPixels support in the future, so here is one: #83

It's a little embarrassing I can't understand PR, I'm a UX/UI designer, who was trying hard to practice code to no avail although.¹

Could you explain to me what's going on?


¹ I wish I can learn JS, but lack of help has been holding me back because it's not only JS, it's the programming language I do not know how to approach and figure out how to solve problems, I know syntaxes, but I don't know how to write a program. :)

@rugk
Copy link
Owner

rugk commented Mar 9, 2020

Actually it's a legal problem: The company behind these emojis wants to make money, and does not allow one to use the (new emoji) images without a special contract.
So the emojis included in the latest version of this add-on are still the old ones – before they did this.
And when they changed their approach they've also renamed the company from EmojiOne to JoyPixels.


Everyone can learn JS – even cats. 🐈 No seriously it just takes some practice (in any programming language that is for beginners). Anyway, that's rather off-topic here.

@rugk
Copy link
Owner

rugk commented Mar 20, 2020

So emoji-mart v3.0.0 has been integrated here, which removes EmojiOne support. Closing this here then, as there is nothing to do now, anymore.

Unfortunately: 🤷‍♂️ 😢

I stay interesting in potentially going through some legal hooks to get support back or so, but please follow #83 for that.

@rugk rugk closed this as completed Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants