Skip to content

Commit

Permalink
Suppress exceptions from telemetry send (reflex-dev#4564)
Browse files Browse the repository at this point in the history
  • Loading branch information
masenf authored Dec 20, 2024
1 parent d8e9881 commit 28568fd
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
1 change: 1 addition & 0 deletions reflex/reflex.py
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,7 @@ def login(loglevel: constants.LogLevel = typer.Option(config.loglevel)):

validated_info = hosting_cli.login()
if validated_info is not None:
_skip_compile() # Allow running outside of an app dir
telemetry.send("login", user_uuid=validated_info.get("user_id"))


Expand Down
10 changes: 6 additions & 4 deletions reflex/utils/telemetry.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import multiprocessing
import platform
import warnings
from contextlib import suppress

from reflex.config import environment

Expand Down Expand Up @@ -171,10 +172,11 @@ def _send(event, telemetry_enabled, **kwargs):
if not telemetry_enabled:
return False

event_data = _prepare_event(event, **kwargs)
if not event_data:
return False
return _send_event(event_data)
with suppress(Exception):
event_data = _prepare_event(event, **kwargs)
if not event_data:
return False
return _send_event(event_data)


def send(event: str, telemetry_enabled: bool | None = None, **kwargs):
Expand Down

0 comments on commit 28568fd

Please sign in to comment.