Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add stepfun integrations #17514

Merged
merged 9 commits into from
Jan 16, 2025
Merged

Conversation

bestony
Copy link
Contributor

@bestony bestony commented Jan 14, 2025

Description

Add new LLM Vendor named "stepfun" for https://platform.stepfun.com/

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 14, 2025
@bestony bestony changed the title WIP: feat: add stepfun integrations feat: add stepfun integrations Jan 15, 2025
@bestony
Copy link
Contributor Author

bestony commented Jan 15, 2025

@masci
can you help me review my PR? i need at least 1 approving review for run CI check.

@bestony
Copy link
Contributor Author

bestony commented Jan 15, 2025

localhost run result :
image

sample code

from llama_index.llms.stepfun import StepFun
from llama_index.core.llms import ChatMessage

llm = StepFun(
    api_key="",
    max_tokens=256,
    context_window=4096,
    model="step-1v-8k",
)

message = ChatMessage(role="user", content="Tell me a joke")
resp = llm.chat([message])
print(resp)

Copy link
Member

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments. Can you also fix the linting problems? If you install our pre-commit hook that should be super easy pre-commit install

@bestony
Copy link
Contributor Author

bestony commented Jan 15, 2025

done with pre-commit @masci

@bestony bestony requested a review from masci January 15, 2025 11:16
Copy link
Member

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the linting?

@bestony
Copy link
Contributor Author

bestony commented Jan 16, 2025

let me run line local & fix it!

@bestony
Copy link
Contributor Author

bestony commented Jan 16, 2025

@masci waiting approve for run lint.

& all pass in my laptop
image

@bestony bestony requested a review from masci January 16, 2025 11:35
@bestony
Copy link
Contributor Author

bestony commented Jan 16, 2025

image
build package error due to install poetry error. I think i can do nothing to fix this. @masci

@masci masci merged commit 97bd056 into run-llama:main Jan 16, 2025
11 checks passed
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 16, 2025
@masci
Copy link
Member

masci commented Jan 16, 2025

@bestony the package publishing job is failing because we don't have write permissions on https://pypi.org/project/llama-index-llms-stepfun/ - My bad I didn't check the package already existed. Best course of action would be you yank the existing releases and add jerryjliu as maintainer.

@bestony
Copy link
Contributor Author

bestony commented Jan 17, 2025

@masci my bad, i think i need publish it first. i add jerryjliu as owner, so maybe in next version, pkackage publish job will work fine!
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants