Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cloudfront distribution #821

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Conversation

bigbitbus
Copy link
Contributor

Description

Added WAF documentation into cloudfront docs.

Safety checklist

n/a - its only docs

  • [ X] This change is backwards compatible and safe to apply by existing users
  • [ X] This change will NOT lead to data loss
  • [ X] This change will NOT lead to downtime who already has an env/service setup

How has this change been tested, beside unit tests?

manually

@bigbitbus bigbitbus requested a review from NitinAgg April 14, 2022 15:34
@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #821 (61964a7) into main (7c4d392) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #821   +/-   ##
=======================================
  Coverage   73.60%   73.60%           
=======================================
  Files         116      116           
  Lines        7703     7703           
=======================================
  Hits         5670     5670           
  Misses       2033     2033           
Flag Coverage Δ
unittests 73.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c4d392...61964a7. Read the comment docs.

Copy link
Collaborator

@NitinAgg NitinAgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No change to the doc generation script?

@bigbitbus bigbitbus merged commit c73efc5 into main Apr 19, 2022
@bigbitbus bigbitbus deleted the feature/add-waf-documentation branch April 19, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants