-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring Your Own Kubernetes: EKS support MVP #829
Conversation
Codecov Report
@@ Coverage Diff @@
## main #829 +/- ##
==========================================
- Coverage 74.10% 73.96% -0.14%
==========================================
Files 119 120 +1
Lines 7831 7905 +74
==========================================
+ Hits 5803 5847 +44
- Misses 2028 2058 +30
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but maybe add a warning about the limitations?
This reverts commit d4a6427.
@juandiegopalomino I added a warning for the user to save their terraform state files. |
Description
Allow deploying a k8s service with Opta using the default
~/.kube/config
or theKUBECONFIG
env var.This was implemented by adding a Opta registry for Helm. Which means if the user defines a k8s-service and doesn't set a provider or an environment file - we would use their local Kubeconfig to deploy that service with Opta.
Limitations:
We can address these limitations in the future, we have tickets for them in our backlog under the epic BYOK Extra Features.
See the documentation page for more information - included with this PR.
Safety checklist
How has this change been tested, beside unit tests?
Tested on a EKS cluster created with
k8s-cluster
but NOT withk8s-base
- instead I ran the terraform files provided with the example and then I ranopta apply
on this file.https://www.loom.com/share/ef29c8ca7b26441e8b300f87dd900009?sharedAppSource=personal_library