Fix tests failing if run with OPTA_DISABLE_REPORTING=1 #831
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you run Python tests (i.e.
make test
) locally whileOPTA_DISABLE_REPORTING=1
is set in your terminal, tests will fail because the datadog and amplitude tests rely on that env var not being set when the test is run, but they do not validate that assumption. This PR adds a pytest fixture that makes it easy to handle that case.The
hide_debug_mode
fixture unsets configured env vars (currently, onlyOPTA_DISABLE_REPORTING
) as well assys._called_from_test
during the test and restores the original values after the test. It is defined intests/conftest.py
to make it available to any test undertests/
.This PR also removes
# noqa
lines from the amplitude and datadog test files as part of cleanup.Safety checklist
How has this change been tested, beside unit tests?
This change only affects unit tests.