Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a max helm history field for k8sservice #835

Merged
merged 2 commits into from
Apr 18, 2022

Conversation

juandiegopalomino
Copy link
Collaborator

Description

Cause a problem Will was facing is that he made hundreds of deployments and so the history was obscenely large

Safety checklist

  • This change is backwards compatible and safe to apply by existing users
  • This change will NOT lead to data loss
  • This change will NOT lead to downtime who already has an env/service setup

How has this change been tested, beside unit tests?

YOUR_ANSWER

Cause a problem Will was facing is that he made hundreds of deployments and so the history was obscenely large
@codecov
Copy link

codecov bot commented Apr 16, 2022

Codecov Report

Merging #835 (8d7a8cb) into main (1091f58) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #835   +/-   ##
=======================================
  Coverage   74.06%   74.06%           
=======================================
  Files         119      119           
  Lines        7821     7821           
=======================================
  Hits         5793     5793           
  Misses       2028     2028           
Flag Coverage Δ
unittests 74.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1091f58...8d7a8cb. Read the comment docs.

Copy link
Contributor

@bigbitbus bigbitbus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why should this be a configurable parameter? Are there too many history entries for a customer?

Why not set default to 0 (infinite)? Its not problemmatic for most people, and gives them all their history...

@nsarupr
Copy link
Contributor

nsarupr commented Apr 18, 2022

Should we keep the default value for max_history as 0, the same as terraform does?

@juandiegopalomino juandiegopalomino merged commit b99b18d into main Apr 18, 2022
@juandiegopalomino juandiegopalomino deleted the jd/max-history branch April 18, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants